Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ebay-menu, ebay-filter-menu: arrow keydown event doesn't always fire #2294

Open
cynthiahhc opened this issue Oct 16, 2024 · 3 comments
Open

Comments

@cynthiahhc
Copy link

cynthiahhc commented Oct 16, 2024

Bug Report

eBayUI Version: 14.3.0

Description

#2268

The arrow keydown event does not always fire. The event doest not fire the up arrow keydown event when it is the first index and does not fire the down arrow keydown event when it is the last index. Also the index emitted is using the roving tab index instead of the actual index when the keydown event happens, which is intentional, but it is not very clear. Maybe we should provide both actual index and the roving index.

Our use case is to move to the second menu while the user presses down arrow at the last index of the first menu, or press the up arrow at the first index of the second menu to move to the first menu.

Workaround

No work around

Screenshots

N/A

@agliga
Copy link
Contributor

agliga commented Oct 30, 2024

Could you share your usecase for this?
Ideally if its at the end we wouldn't fire an on-keydown event since its not doing anything.
If you have multiple menus, shouldn't you navigate to them with tab? Or maybe add a divider between each menu?

@cynthiahhc
Copy link
Author

We are trying to traverse from the last option (5G) in Frequently selected section to the first option (2G) in All option section.
Screenshot 2024-11-20 at 10 25 46

@cynthiahhc
Copy link
Author

Since they're separate menu with different menu name, we cannot just add a divider to separate it. The current implementation is to traverse through tab, but it is confusing to the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants