Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support loading new Flutter 3.19 Cupertino font families #189

Closed
wants to merge 1 commit into from

Conversation

kuhnroyal
Copy link
Contributor

@coreysprague
Copy link
Contributor

Thanks @kuhnroyal -- we've been neglecting this package as of late, but will jump on this PR this week and roll a new version along with other misc updates

We also need to find a new approach to loading fonts as the the AssetManifest.json that we rely on is soon going away.

@RafaelPlantard
Copy link

any news?

@kuhnroyal
Copy link
Contributor Author

Hey @coreysprague, hope everything is alright. Any plans to merge this? And to generally keep this package alive?

@befirst
Copy link

befirst commented Sep 12, 2024

Please merge it, now it's impossible to test cupertino picker widget without overriding fonts

@coreysprague
Copy link
Contributor

@befirst @kuhnroyal @RafaelPlantard

I deeply apologize, but we have decided to end-of-life this project 😞


This repo is no longer maintained

09/12/2024 Update:

Unfortunately we have made the tough decision to no longer actively maintain this repository. While the package has served us and the community well, we don't have the capacity to give it the attention it deserves.

We realize that this decision means that open pull requests will not be merged. Our hope is that the community will rally and focus their efforts around more actively maintained packages for aiding in golden-based tests.

Once again, we want to thank each and every one of you for your contributions over the years.

Thank you for your understanding.

Best regards,

The eBay Motors App team

@Wreos
Copy link

Wreos commented Oct 4, 2024

@coreysprague @kuhnroyal
Hello,
I actively use this package in my tests (more than 100). Am I allowed to fork your project and publish on my own with different name? If so, on what terms? Should I include ebay copyright?
I plan to continue to support its use.

@kuhnroyal
Copy link
Contributor Author

You can read the LICENSE file and look at the conditions, but please wait a little bit before publishing fork yourself. I contacted eBay via mail and they are currently discussing internally if and how they can hand this project over to the community. They had a lot of people contacting them in this regard.
Having multiple cloned packages published is fragmenting the Flutter ecosystem and doesn't help. Give it a little bit of time please.

@fatherOfLegends
Copy link
Contributor

I want to clarify that the concept of golden tests are built into Flutter. You can continue to have golden tests without this package or a clone of it. This package was just intended to make it more convenient to use them for common use cases we had at eBay. Since then several things have improved within flutter_test and some of this package is outdated. I have been working on updating and republishing this package but I want to include several extensions to Goldens that @CaleyD and I have made and use within Agapé. That said I am not sure it will be a drop in replacement. I agree with @kuhnroyal that it isn't great for the community to introduce multiple published forks but you can absolutely copy the relevant pieces into your projects if you need specific behaviors that are not supported by this package in its current state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support loading new Cupertino fonts in Flutter 3.19
6 participants