Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client.Close() should handle cache release and remove the disconnect callback. #89

Open
hzhou8 opened this issue Jun 18, 2020 · 0 comments
Open

client.Close() should handle cache release and remove the disconnect callback. #89

hzhou8 opened this issue Jun 18, 2020 · 0 comments

Comments

@hzhou8
Copy link
Contributor

hzhou8 commented Jun 18, 2020

Maybe this API is not needed in most situation. However, current implementation has problems:

  1. It doesn't cleanup resources and doesn't preventing the other APIs to continue reading the data. The expected behavior should be cleanup all the cache and all the later API calls for read/write data should fail.

  2. Currently we have auto-reconnect supported. This API need to reset the disconnect callback so that it won't automatically reconnect by itself as a result of Close().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hzhou8