Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(button): add icon only option for small screens #2385

Open
6 tasks
namtheho opened this issue Jul 17, 2024 · 6 comments
Open
6 tasks

feat(button): add icon only option for small screens #2385

namtheho opened this issue Jul 17, 2024 · 6 comments

Comments

@namtheho
Copy link

namtheho commented Jul 17, 2024

Description

For Button module, add an icon only option for small screens.

Engineering pre-requisites

  • Successful design review with Design System Team.
  • Supports dark mode.
  • Supports responsive design.
  • Tokens have been provided (or already exist).
  • Successful accessibility review with Core A11Y Team.
  • Successful frontend review with eBayUI Team.
@agliga
Copy link
Contributor

agliga commented Oct 30, 2024

This is only for trailing icon, the code for turning this into an icon only button will come later

@ArtBlue
Copy link
Contributor

ArtBlue commented Nov 4, 2024

@namtheho , I cannot tag Randy for some reason. The Figma links are not pointing to a trailing button icon. Can we have the actual specs?

@randybascue
Copy link

@ArtBlue Weird that it's doing this again. Here are the specs

@ArtBlue ArtBlue changed the title Button — Update CTA to support trailing icons feat(button): update to support trailing icons Nov 5, 2024
@eBay eBay deleted a comment from namtheho Nov 5, 2024
@ArtBlue
Copy link
Contributor

ArtBlue commented Nov 5, 2024

I removed a comment with an image of the button specs that did not include a trailing icon.

@ArtBlue
Copy link
Contributor

ArtBlue commented Nov 5, 2024

I updated this issue to target button as cta-button is an <a> and cannot have the use case (down chevron for lists) attached to the design specs.

@ArtBlue ArtBlue changed the title feat(button): update to support trailing icons feat(button): add icon only option for small screens Nov 6, 2024
@ArtBlue
Copy link
Contributor

ArtBlue commented Nov 6, 2024

@randybascue , @namtheho , so we actually already have a trailing icon option in Button. Given this, I'm simply repurposing this issue to implement the addition of the icon only option responsively on small screens/container. I'm blocking it for design since we need the specs.

@agliga agliga modified the milestones: 18.5.0, 18.6.0 Nov 14, 2024
@ArtBlue ArtBlue removed this from the 18.6.0 milestone Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

4 participants