Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

table: various fixes #2484

Open
1 task done
saiponnada opened this issue Nov 1, 2024 · 0 comments
Open
1 task done

table: various fixes #2484

saiponnada opened this issue Nov 1, 2024 · 0 comments
Assignees
Milestone

Comments

@saiponnada
Copy link
Contributor

saiponnada commented Nov 1, 2024

I verified there's no existing issue for this bug.

  • There are no existing issues

Current behavior

Currently we use aria-pressed to toggle between states. aria-pressed is ideal only for two states. For table sorting, we have three states 1. asc 2. desc 3. no sort.

Expected behavior

Use custom logic similar to below example

<button type="button" onclick="toggleSort(this)">
    Title
    <span class="asc" aria-hidden="true">↑</span>
    <span class="desc" aria-hidden="true">↓</span>
    <span class="other" aria-hidden="true">↝</span>
</button>

https://a11ysupport.io/tests/html/aria/aria-sort.html

Skin version

18.4.0

@agliga agliga added this to eBayUI Dec 19, 2024
@agliga agliga added this to the 19.0.0 milestone Dec 19, 2024
@agliga agliga moved this to Todo in eBayUI Dec 19, 2024
@agliga agliga changed the title table: remove aria-pressed for sorting table: various fixes Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

2 participants