Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

listbox: align listbox focus states with Design System spec #2487

Open
3 tasks
cordeliadillon opened this issue Nov 5, 2024 · 1 comment
Open
3 tasks

listbox: align listbox focus states with Design System spec #2487

cordeliadillon opened this issue Nov 5, 2024 · 1 comment
Labels
blocked: design design system type: enhancement

Comments

@cordeliadillon
Copy link
Contributor

cordeliadillon commented Nov 5, 2024 •
edited
Loading

Description

There seems to be a mismatch between the listbox focus styles in our Design System design specs and our Skin implementation. Let's ensure they align.

Screenshots

Skin:
Screenshot 2024-11-05 at 10 06 52

eBay UI Core:
Screenshot 2024-11-05 at 10 07 49

eBay UI Core React:
Screenshot 2024-11-05 at 10 08 02

Figma link

No response

Engineering pre-requisites

  • Supports dark mode.
  • Supports responsive design.
  • Tokens have been provided (or already exist).
@cordeliadillon
Copy link
Contributor Author

@randybascue can you provide specs for focus state when focus is in listbox?

@agliga agliga added this to eBayUI Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked: design design system type: enhancement
Projects
eBayUI
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@agliga @cordeliadillon