Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabio Health Check #200

Closed
cookandy opened this issue Apr 7, 2016 · 12 comments
Closed

Fabio Health Check #200

cookandy opened this issue Apr 7, 2016 · 12 comments

Comments

@cookandy
Copy link
Contributor

cookandy commented Apr 7, 2016

The Consul service check for Fabio is using port 9998 instead of port 81 and shows it as failing. Can this be configured?

@cookandy
Copy link
Contributor Author

cookandy commented Apr 7, 2016

I also don't see my services being registered in Fabio. I left the Marathon deployment script the same as with HAProxy and only updated

START_CONSUL_TEMPLATE=false
START_FABIO=true

Does the Marathon script need to be updated?

@sielaq
Copy link
Contributor

sielaq commented Apr 7, 2016

regarding port:
we used default one, but you can use ENV variable to set a different one:

ui_addr = :9998

just add that one to restricted/env
you can modify ANY of FABIO parameter by ENV variable just use _ instead of .
for all properties in example file:
https://raw.githubusercontent.com/eBay/fabio/master/fabio.properties

regarding registering into fabio:
you have to use a specific TAG
see an example:
https://github.com/eBayClassifiedsGroup/PanteraS/blob/master/examples/SmoothWebappPython/deploy0_marathon.json#L19

@cookandy
Copy link
Contributor Author

cookandy commented Apr 7, 2016

Thanks @sielaq. If I'm understanding you correctly, I could also just export:

registry_consul_register_ip = :81

Correct?

I will update the TAG to reflect Fabio configuration - thanks.

@sielaq
Copy link
Contributor

sielaq commented Apr 7, 2016

correct

@cookandy
Copy link
Contributor Author

cookandy commented Apr 7, 2016

I added registry_consul_register_ip = :81 to restricted/env, however, the health check is still registering on 9998.

I suggest we add registry.consul.register.ip = :81 to fabio.properties

@sielaq
Copy link
Contributor

sielaq commented Apr 7, 2016

sorry for my nonchalance :) there NOT supposed to be any space - those are ENV variables

ui_addr=:81
registry_consul_register_ip=:81

@sielaq
Copy link
Contributor

sielaq commented Apr 7, 2016

Let me try , probably sth else is missing

@sielaq
Copy link
Contributor

sielaq commented Apr 7, 2016

Looks like a bug in fabio I will open issue for it

@sielaq
Copy link
Contributor

sielaq commented Apr 7, 2016

fabiolb/fabio#77

@cookandy
Copy link
Contributor Author

cookandy commented Apr 7, 2016

Thanks @sielaq. I'll keep an eye out..

@sielaq
Copy link
Contributor

sielaq commented Apr 7, 2016

this is documentation issue
please use registry_consul_register_addr=:81 instead

so try:

ui_addr=:81
registry_consul_register_addr=:81

@cookandy
Copy link
Contributor Author

cookandy commented Apr 7, 2016

Ah, yes, that was it - thanks! I suggest we add registry.consul.register.addr=:81 to fabio.properties

@cookandy cookandy closed this as completed Apr 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants