fix: Using canvas as a direct source #701
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's supposed to be possible to use a canvas as a direct source, with either of:
html2pdf().from(canvas).save()
etc.html2pdf().set({ canvas: canvas }).save()
etc.But there were two errors preventing this from working:
getType
when usingtoLowerCase()
, meaning the.from()
approach didn't workpageSize
initialization intoPdf
, meaning both approaches didn't workThis PR should solve the issue - added the
all-tags_canvas.pdf
snapshot test to verify the fix.Closes #699