Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New method update_until_and_get_variables #152

Open
BSchilperoort opened this issue Jul 11, 2024 · 1 comment
Open

New method update_until_and_get_variables #152

BSchilperoort opened this issue Jul 11, 2024 · 1 comment

Comments

@BSchilperoort
Copy link
Member

Communication with grpc4bmi is quite slow. Often much slower than updating a locally running model. In many workflows this makes users not want to use containerized models (especially for 1D models).

We could speed up their workflows with a new grpc4bmi method update_until_and_get_variables, which:

  • Takes a time to update until, and the names of variables the user wants to store
  • The grpc server will update the model, and store the variables
  • Once the target time is reached, the grpc server will transfer the collected data to the user

As there is a loop running inside the container, this will greatly improve performance.

@BSchilperoort
Copy link
Member Author

Another way to improve performance could also be to use a rust grpc server (with Python bindings e.g. pyo3).

"tonic", a rust gRPC server+client is 20x faster than python's grpc (which is one of the slowest gRPC implementations).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant