Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in easygpio_inputGet ? #7

Open
hyarion opened this issue Nov 14, 2016 · 0 comments
Open

Typo in easygpio_inputGet ? #7

hyarion opened this issue Nov 14, 2016 · 0 comments

Comments

@hyarion
Copy link

hyarion commented Nov 14, 2016

I don't know if this will solve the bug you describe in the comment (haven't tried it) but it looks like there might be a typo in the implementation of easygpio_inputGet on line 301: https://github.com/eadf/esp8266_easygpio/blob/master/easygpio.c#L301

// this does *not* work, maybe GPIO_IN_ADDRESS is the wrong address
return ((GPIO_REG_READ(GPIO_IN_ADDRESS) > gpio_pin)  & 1UL);

Shouldn't that > be a >> instead?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hyarion