Full-width characters break gutter annotations

[20chan]

• GitLens Version: 4.4.1
• VSCode Version: 1.15.1
• OS Version: Windows 10

When commit message contains fullwidth chracter happens.

[eamodio]

This is a duplicate of #107 and sadly it depends on the font used.

[20chan]

I'm using monospace font but it doesn't work. Isn't there any way to calculate length of string using full-width character as two character?

[eamodio]

Unfortunately as I understand it (from the vscode issue around it) only certain monospace fonts actually render full-width characters as double-width. If the font does, like Inconsolata, then it works, otherwise it won't. But AFAIK, there is nothing I can do as a vscode extension to get that to work -- maybe it is something vscode can do, but again I don't know. Here is the vscode issue: microsoft/vscode#14589

[20chan]

I think you didn't understane what's the problem. I'm using monospace font, and it works.

What I want to tell you is, you shouldn't pad just using length of string. Maybe you should use isHalfWidth in eastasianwidth or something to pad actual length of string.

[eamodio]

@Phillyai can you try the Inconsolata font and see if you are still having an issue?

I am currently using the string-width library to calculate the width of the line to pad it. string-width looks to be almost the same as the east-asian-width library.

[20chan]

Inconsolata used, still have issue.

> s=require('string-width')
[Function]
> s('가나다')
6

And also string-width seems working well.

[eamodio]

@Phillyai is this a public repo that I can try out for myself? Also can you try setting: "gitlens.annotations.file.gutter.compact": false to see if you see the same behavior?

Also if you are interested I have a GitLens slack -- might be easier to talk about this.

[20chan]

1. Sure, yes. Also there are many repository contains korean commit messages not only this. https://github.com/phillyai/bumble
2. Sadly, yes.
   

[eamodio]

@Phillyai I think I see the issues. One is with the compact mode where I wasn't using string-width, and the other is my truncation function doesn't work properly with full-width characters.

[eamodio]

@Phillyai Just released v4.4.2 -- it should hopefully fix these issues. Thanks again for being persistent on this one!

[20chan]

I'm sorry, it's much better but it still have issue. Three dots character makes line little bit longer.

[eamodio]

@Phillyai what font is that? (Also is that file in the repo?)

This is what I see with Inconsolata (in the lexer.py file)

[20chan]

I'm using Inconsolata, same as you, and sorry, this is another repository.
Also I tried lexer.py in bumble, and it is working very well.

[eamodio]

OK -- I'll check that one out -- thank you!

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.