Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line annotations some times mess with white space. #176

Closed
mcarpenterjr opened this issue Oct 20, 2017 · 10 comments
Closed

Line annotations some times mess with white space. #176

mcarpenterjr opened this issue Oct 20, 2017 · 10 comments
Assignees
Labels
bug Something isn't working

Comments

@mcarpenterjr
Copy link

  • GitLens Version: 5.7.1
  • VSCode Version: 1.18.0 - insider
  • OS Version: Linux Mint 18.2

Steps to Reproduce:

  1. Write some code in a pre-existing repository
  2. Create a new line and press tab, get more whitespace than expected.

Sometimes when writing code if the annotation passes the soft break the workspace scrolls way off to the side also.

If lens is disabled or removed the problem goes away.

Otherwise great extension.

@eamodio eamodio added the needs-more-info Needs further information, steps, details, etc. label Oct 20, 2017
@eamodio
Copy link
Member

eamodio commented Oct 20, 2017

Can you provide more details -- what type of file? what language? Also can you maybe include a screen capture of it?

I can't reproduce the behavior, but I'm not sure I'm doing it properly.

@mcarpenterjr
Copy link
Author

I've noticed this in JS, HTML, and PHP

It happens what seems like randomly, I will try and get a gif for you.

@eamodio eamodio added the bug Something isn't working label Oct 22, 2017
@eamodio
Copy link
Member

eamodio commented Oct 25, 2017

@mcarpenterjr could the issue you are seeing be this one: microsoft/vscode#36873?

@mcarpenterjr
Copy link
Author

Nope, it's the line annotations from gitlens, I have a better understanding of what's occuring now. It does happen at what seems like random so it's hard to capture the behavior through Peek to create a gif.

This occurs in CSS JS HTML and PHP files.

While coding the line annotation (the light gray entry that has the user's name time of last commit and the commit title) will appear, this forces the cursor to the end of the annotation, the annotation will then disappear just as quickly as it appeared but leave behind excessive white space. What I would assume is padding around the annotation.
In cases where the line is long and is approaching the softwrap bar, the annotation will actually ignore the softwrap and cause the workspace to scroll horizontally. What it seems like is occurring is the cursor is getting pushed into the great beyond past the softwrap and forces the view to scroll.

Also, I managed to get a partial instance of this occurring...
wooo

@eamodio
Copy link
Member

eamodio commented Nov 14, 2017

OK, I have posted on microsoft/vscode#34441, which I think this is related to.

Although from your gif -- do you have your auto-save set to some extremely small timeout? Because GitLens should be not showing those annotations while you are editing (i.e. unsaved)

@mcarpenterjr
Copy link
Author

Autosave is on, I have not changed the timeout, so maybe that needs a BUMP.

@mcarpenterjr
Copy link
Author

The default for autosave is 1000... ms? that's low.

@eamodio
Copy link
Member

eamodio commented Nov 14, 2017

Hrm, every second is pretty low. I'm guessing part of the problem is that I debounce the events and if its getting hit with a bunch of save/dirty/save/dirty events I am likely skipping some. I'll have to think a bit on how best to protect against that.

Thanks for the extra info!

@eamodio eamodio self-assigned this Nov 17, 2017
@eamodio eamodio added this to the Soon™ milestone Nov 17, 2017
@eamodio eamodio removed the needs-more-info Needs further information, steps, details, etc. label Nov 17, 2017
@mcarpenterjr
Copy link
Author

bitmoji

@eamodio eamodio removed this from the Soon™ milestone Jul 19, 2019
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants