Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitlens.advanced.quickPick.closeOnFocusOut setting should be reversed #239

Closed
ghost opened this issue Dec 31, 2017 · 2 comments
Closed

gitlens.advanced.quickPick.closeOnFocusOut setting should be reversed #239

ghost opened this issue Dec 31, 2017 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@ghost
Copy link

ghost commented Dec 31, 2017

The option is documented as follows:

gitlens.advanced.quickPick.closeOnFocusOut 	Specifies whether or not to close the QuickPick menu when focus is lost

This, to me, implies that if it is true then the quickpick should close when it loses focus. But internally this option changes meaning to QuickPickIgnoreFocusOut:

export function getQuickPickIgnoreFocusOut() {
    return configuration.get<boolean>(configuration.name('advanced')('quickPick')('closeOnFocusOut').value);
}

I think the option should be inverted internally to make more sense and fit the documentation.

@eamodio eamodio self-assigned this Jan 2, 2018
@eamodio eamodio added the bug Something isn't working label Jan 2, 2018
@eamodio eamodio added this to the Soon™ milestone Jan 2, 2018
@eamodio eamodio changed the title Misleading config option "gitlens.advanced.quickPick.closeOnFocusOut" gitlens.advanced.quickPick.closeOnFocusOut should be reversed Jan 2, 2018
@eamodio eamodio changed the title gitlens.advanced.quickPick.closeOnFocusOut should be reversed gitlens.advanced.quickPick.closeOnFocusOut setting should be reversed Jan 2, 2018
@eamodio eamodio closed this as completed in 8fc8f79 Jan 2, 2018
@eamodio
Copy link
Member

eamodio commented Jan 2, 2018

Nice catch -- fixed in 7.2

@eamodio eamodio removed this from the Soon™ milestone Jul 19, 2019
@github-actions
Copy link

github-actions bot commented Jun 2, 2021

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant