Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken "gitlens.blame.line.enabled" setting #242

Closed
mafflin opened this issue Jan 15, 2018 · 10 comments
Closed

Broken "gitlens.blame.line.enabled" setting #242

mafflin opened this issue Jan 15, 2018 · 10 comments
Assignees
Labels
bug Something isn't working

Comments

@mafflin
Copy link

mafflin commented Jan 15, 2018

"gitlens.blame.line.enabled" setting not working anymore

  • GitLens Version: 7.5.1
  • VSCode Version: 1.19.2
  • OS Version: Arch Linux

Steps to Reproduce:

  1. Add setting "gitlens.blame.line.enabled": false,
  2. Nothing happens. Option is not working.
@douglarek
Copy link

douglarek commented Jan 15, 2018

yeah, it is true, I got this too. But very strange, it is ok now when I set it true, then false again.

@WoodyWoodsta
Copy link

@douglarek That fix works for a while and then it seems to revert. Not sure what might be triggering the revert.

@douglarek
Copy link

@WoodyWoodsta yeah, you are right; so puzzled

@alex-bashkatov-ezlo
Copy link

seems reverted in 1 min for me too

@eamodio
Copy link
Member

eamodio commented Jan 15, 2018

So sorry -- will be putting out a release as soon as I get this fixed (should be soon --- just woke up)

@eamodio eamodio self-assigned this Jan 15, 2018
@eamodio eamodio added the bug Something isn't working label Jan 15, 2018
@eamodio eamodio added this to the Soon™ milestone Jan 15, 2018
@eamodio
Copy link
Member

eamodio commented Jan 15, 2018

Thank you all for your patience -- 7.5.2 has been pushed to the marketplace and should resolve this issue. Please let me know if not. Again sorry for the inconvenience!

@eamodio
Copy link
Member

eamodio commented Jan 15, 2018

microsoft/vscode#15756 can't happen soon enough. Please upvote ;)

@alex-bashkatov-ezlo
Copy link

works like a charm from my side! Thanks for quick fix!

@NeoGenet1c
Copy link

NeoGenet1c commented Feb 1, 2018

If the configuration is being set for the first time ever, the problem persists (with false value).

Switching the value to true reloading VSC and switching back to false seems to make it work.

(I have Mac OS 10.13.2 (17C205), VSCode: Version 1.19.3 (1.19.3))

@eamodio eamodio removed this from the Soon™ milestone Jul 19, 2019
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants