Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed "await" from era5 notebook to get it running #296

Closed
rsignell opened this issue Oct 17, 2024 · 2 comments · Fixed by #298
Closed

Removed "await" from era5 notebook to get it running #296

rsignell opened this issue Oct 17, 2024 · 2 comments · Fixed by #298
Assignees

Comments

@rsignell
Copy link

rsignell commented Oct 17, 2024

When I tried first running the era5 notebook linked in the blog post, I was getting errors like:

TypeError: object IcechunkStore can't be used in 'await' expression

I didn't really know what I was doing, but when I removed the await references, I got the notebook to run (using a Coiled Jupyterlab instance on AWS) and the performance seemed similar to Ryan's original results?

@jhamman
Copy link
Member

jhamman commented Oct 17, 2024

Thanks @rsignell - we can take another pass through these notebooks and clean this up. We just changed the store this week to use asynchronous API for the create/open/commit methods.

and the performance seemed similar to Ryan's original results?

Great stuff!

@rsignell
Copy link
Author

No, icechunk is the great stuff!! 😜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants