Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storybook #77

Open
hazel-sudz opened this issue Sep 1, 2020 · 2 comments
Open

Storybook #77

hazel-sudz opened this issue Sep 1, 2020 · 2 comments
Assignees
@Zjjc123 @hazel-sudz
Labels
enhancement New feature or request too much work Good idea but too much work

Comments

@hazel-sudz
Copy link
Member

hazel-sudz commented Sep 1, 2020 •
edited
Loading

Sometimes it's very annoying to test changes made to UI because on a dev server you have to manually copy the login link to look at pretty much anything. Also the you have to relogin on each deploy preview.

We can use something like https://storybook.js.org/ to look at the UI of components in isolation. This also encourages best practices because each "story" has to be created in isolation (props only).

Storybook is very popular and used in enterprise with 7.5 million downloads/month.
@hazel-sudz
Copy link
Member Author

Also we can deploy storybook to something like github pages on pull request to quickly glance at any UI changes

@Zjjc123 Zjjc123 added the enhancement New feature or request label Sep 1, 2020
@hazel-sudz
Copy link
Member Author

This is a lot of work and I don't think it's worth it for something like this so it probably won't happen @Zjjc123

@Zjjc123 Zjjc123 added the too much work Good idea but too much work label May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Zjjc123 Zjjc123

@hazel-sudz hazel-sudz

Labels
enhancement New feature or request too much work Good idea but too much work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Zjjc123 @hazel-sudz