fix: dll missing uglifyJs config

easy-team · Nov 22, 2018 · 34a5b4a · 34a5b4a
1 parent 6acfaf8
commit 34a5b4a
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 9 deletions.
diff --git a/config/config.js b/config/config.js
@@ -21,7 +21,6 @@ exports.base = {
     },
     node: {
       console: false,
-      process: false,
       Buffer: false,
       setImmediate: false
     }

diff --git a/lib/builder.js b/lib/builder.js
@@ -90,6 +90,11 @@ exports.getDllWebpackConfig = (config, option = {}) => {
     if (cli.size) {
       plugins.push(cli.size === true ? { analyzer: true } : { stats: true });
     }
+    // need dll customize uglifyJs config
+    const uglifyJs = utils.getConfigPlugin(config.plugins, 'uglifyJs');
+    if (uglifyJs) {
+      plugins.push({ uglifyJs });
+    }
     dll.forEach(item => {
       const tmpConfig = utils.cloneDeep(config);
       const dllConfig = merge(tmpConfig, { entry: null, dll: null, plugins }, { dll: item }, item.webpackConfig);

diff --git a/lib/core/plugin.js b/lib/core/plugin.js
@@ -4,14 +4,7 @@ const chalk = require('chalk');
 module.exports = {
 
   getConfigPlugin(label) {
-    const plugins = this.config.plugins || {};
-    if (Array.isArray(plugins)) {
-      const plugin = plugins.find(item => {
-        return item.hasOwnProperty(label);
-      });
-      return plugin && plugin[label];
-    }
-    return plugins[label];
+    return this.utils.getConfigPlugin(this.config.plugins, label);
   },
 
   getPluginByName(label) {

diff --git a/utils/utils.js b/utils/utils.js
@@ -563,4 +563,14 @@ utils.getPluginLabel = plugin => {
   return md5(plugin.apply.toString());
 };
 
+utils.getConfigPlugin = (plugins = {}, label) => {
+  if (Array.isArray(plugins)) {
+    const plugin = plugins.find(item => {
+      return item.hasOwnProperty(label);
+    });
+    return plugin && plugin[label];
+  }
+  return plugins[label];
+};
+
 module.exports = utils;