Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TensorFlow 1.7.0 checksum changed #6146

Closed
Serpens opened this issue Apr 11, 2018 · 5 comments
Closed

TensorFlow 1.7.0 checksum changed #6146

Serpens opened this issue Apr 11, 2018 · 5 comments
Milestone

Comments

@Serpens
Copy link
Contributor

Serpens commented Apr 11, 2018

Another case of GitHub source checksums changing, as described in #5151

In TensorFlow-1.7.0-foss-2018a-Python-3.6.4.eb, current checksum for v1.7.0.tar.gz should be c676a96fc8700722816b2b98c85578b2f99fac7a7b2484c9c7f0641484f8d50d

@boegel
Copy link
Member

boegel commented Apr 11, 2018

I can confirm the changed checksum for TF 1.7.0, but what's strange is that the checksums did not change for TF 1.6.0 or 1.5.0, so this looks like a re-release without changing the version number... 😲

@boegel boegel added this to the 3.6.0 milestone Apr 11, 2018
@boegel
Copy link
Member

boegel commented Apr 11, 2018

Re-release confirmed, the diff between the old 1.7.0 and the new one is shown below.

Great release management of the @tensorflow team...

diff -ru tensorflow-1.7.0.old/tensorflow/contrib/cluster_resolver/python/training/tpu_cluster_resolver.py tensorflow-1.7.0.new/tensorflow/contrib/cluster_resolver/python/training/tpu_cluster_resolver.py
--- tensorflow-1.7.0.old/tensorflow/contrib/cluster_resolver/python/training/tpu_cluster_resolver.py	2018-03-28 20:54:13.000000000 +0200
+++ tensorflow-1.7.0.new/tensorflow/contrib/cluster_resolver/python/training/tpu_cluster_resolver.py	2018-03-29 06:18:40.000000000 +0200
@@ -73,7 +73,7 @@
                zone=None,
                project=None,
                job_name='worker',
-               coordinator_name='coordinator',
+               coordinator_name=None,
                coordinator_address=None,
                credentials='default',
                service=None):
diff -ru tensorflow-1.7.0.old/tensorflow/contrib/cluster_resolver/python/training/tpu_cluster_resolver_test.py tensorflow-1.7.0.new/tensorflow/contrib/cluster_resolver/python/training/tpu_cluster_resolver_test.py
--- tensorflow-1.7.0.old/tensorflow/contrib/cluster_resolver/python/training/tpu_cluster_resolver_test.py	2018-03-28 20:54:13.000000000 +0200
+++ tensorflow-1.7.0.new/tensorflow/contrib/cluster_resolver/python/training/tpu_cluster_resolver_test.py	2018-03-29 06:18:40.000000000 +0200
@@ -117,7 +117,8 @@
         zone=None,
         tpu=['test-tpu-1'],
         credentials=None,
-        service=self.mock_service_client(tpu_map=tpu_map))
+        service=self.mock_service_client(tpu_map=tpu_map),
+        coordinator_name='coordinator')
 
     actual_cluster_spec = tpu_cluster_resolver.cluster_spec()
     expected_proto = """
@@ -170,6 +171,7 @@
         project='test-project',
         zone='us-central1-c',
         tpu=['test-tpu-1'],
+        coordinator_name='coordinator',
         coordinator_address='10.128.1.5:10203',
         credentials=None,
         service=self.mock_service_client(tpu_map=tpu_map))
@@ -196,6 +198,7 @@
         project='test-project',
         zone='us-central1-c',
         tpu='test-tpu-1',
+        coordinator_name='coordinator',
         coordinator_address='10.128.1.5:10203',
         credentials=None,
         service=self.mock_service_client(tpu_map=tpu_map))
@@ -239,7 +242,8 @@
     tpu_cluster_resolver = TPUClusterResolver(
         tpu='test-tpu-1',
         credentials=None,
-        service=self.mock_service_client(tpu_map=tpu_map))
+        service=self.mock_service_client(tpu_map=tpu_map),
+        coordinator_name='coordinator')
 
     actual_cluster_spec = tpu_cluster_resolver.cluster_spec()
     expected_proto = """

@boegel
Copy link
Member

boegel commented Apr 11, 2018

Asked for more information upstream, see tensorflow/tensorflow#18424

@boegel
Copy link
Member

boegel commented Apr 11, 2018

checksum fixed in #6147

@boegel
Copy link
Member

boegel commented Apr 12, 2018

#6147 merged, confirmation & feedback received from TensorFlow team on this issue, so closing this

Thanks for reporting this @Serpens!

@boegel boegel closed this as completed Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants