Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot upload Image #73

Closed
petyots opened this issue Apr 23, 2019 · 8 comments
Closed

Cannot upload Image #73

petyots opened this issue Apr 23, 2019 · 8 comments
Labels
bug Something isn't working

Comments

@petyots
Copy link
Contributor

petyots commented Apr 23, 2019

Hello again :)
I just tried to upload a single image following your guide and there seems to be a error
image
I think it's because of wrongly typed property in some of the components but i am still tryin to find it... Thanks in advance

@ebess
Copy link
Owner

ebess commented Apr 24, 2019

Hi,
would you mind sharing your field / model configuration & image you are trying to upload?

@ebess ebess added the bug Something isn't working label Apr 24, 2019
@petyots
Copy link
Contributor Author

petyots commented Apr 24, 2019

Hi this is the photo i am trying to upload:
Screenshot 2019-04-01 at 16 40 37

this the field config in the resource:
return [ ID::make()->sortable(), new Panel('General', [ Images::make('Logo', 'logo')->conversion('logo'), Translatable::make([ Text::make('Name'), Text::make('Slug')->hideFromIndex(), Textarea::make('Short Description')->hideFromIndex() ]), BelongsTo::make('Status', 'status'), Boolean::make('Display', 'display'), Textarea::make('Notes'), ]), ]

This is the model (only the conversions and the collections )

`
public function registerMediaCollections()
{
$this->addMediaCollection('logo')->singleFile();
$this->addMediaCollection('cover')->singleFile();
$this->addMediaCollection('gallery');
}

public function registerMediaConversions(Media $media = null)
{
    $this->addMediaConversion('logo')
        ->width(150)
        ->height(150);
}

`

P.S I tried without Panel also

@ebess
Copy link
Owner

ebess commented Apr 25, 2019

working fine for me. have you tried to remove all other fields but the images?
which browser are you using?

@blocklogic-au
Copy link
Contributor

Hi Guys, I ran into this issue this afternoon, and as I need this for a project with a deadline, and not one who can sleep with weird bugs I went ahead and sorted it out.

Was in Scissors.vue.

In the process of sorting that out there was a breaking change in loading components so I added .default to the end of the imports as well.

Have submitted a pull request.

#77

Thanks
Ben

@xenonthong
Copy link

Having the same exact issue here too.

@ebess
Copy link
Owner

ebess commented Apr 29, 2019

@tigerstrikemedia ty, 2.5.3 released

@ebess ebess closed this as completed Apr 29, 2019
@xenonthong
Copy link

xenonthong commented Apr 30, 2019

@ebess Packagist 2.5.3 still doesn't contain this fix though. Did a composer update, but the issue is still there.

@blocklogic-au
Copy link
Contributor

@ebess Confirming that the 2.5.3 release does not contain my fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants