Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Actions for Windows CI #117

Merged
merged 8 commits into from
Aug 28, 2020
Merged

Github Actions for Windows CI #117

merged 8 commits into from
Aug 28, 2020

Conversation

sekineh
Copy link
Collaborator

@sekineh sekineh commented Aug 27, 2020

Closes #113

This PR will enable CI test on Windows platform using GitHub actions. It builds and tests in three feature configurations:

  • default features (no --features flag)
  • --features tokio
  • --features full

Used pcap version is:

  • WinPcap 4.1.3 + WpdPack 4.1.2 (npcap is not tested in CI because It does not support silent install.)

Other notes:

@sekineh sekineh mentioned this pull request Aug 27, 2020
@sekineh
Copy link
Collaborator Author

sekineh commented Aug 27, 2020

Note: they say silent install of npcap is only available in Npcap OEM.
microsoft/winget-pkgs#468 (comment)
image

I'm going to use WinPcap which I've successfully installed silently before:
https://github.com/sekineh/pcap-alt/blob/315c846928a95e04e590f87ef9b5e9c6d34608e5/appveyor.yml#L42

@sekineh sekineh requested a review from Wojtek242 August 27, 2020 08:16
@sekineh
Copy link
Collaborator Author

sekineh commented Aug 27, 2020

@Wojtek242 , I think it's ready to be reviewed.

Copy link
Collaborator

@Wojtek242 Wojtek242 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@sekineh sekineh changed the title [WIP] Github Actions for Windows CI Github Actions for Windows CI Aug 28, 2020
@sekineh sekineh merged commit 30315e5 into master Aug 28, 2020
@sekineh sekineh deleted the sekineh-github-actions branch August 28, 2020 00:38
@Wojtek242 Wojtek242 mentioned this pull request Aug 28, 2020
@Trolldemorted Trolldemorted mentioned this pull request Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows CI
2 participants