Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code linting as a PR quality check #682

Open
2 of 11 tasks
amnonkhen opened this issue Feb 24, 2022 · 2 comments
Open
2 of 11 tasks

code linting as a PR quality check #682

amnonkhen opened this issue Feb 24, 2022 · 2 comments
Assignees

Comments

@amnonkhen
Copy link
Contributor

amnonkhen commented Feb 24, 2022

We should use linters to make sure our code is up to our quality standards.
Failure to meet the standard would disallow merge of the PR.

See discussion about linting rules

Acceptance Criteria:

  • relevant errors
  • not too many errors
  • easy enough to inspect error messages

Tasks/Questions:

  • should this be integrate with gitlab ci or as a github action? 1st step would be github action
  • should disallow pr merge when there are errors
  • rules for python - see .pylintrc and .flake8 files

for next steps:

  • rules for java - do in ingest-core
  • rules for javascript/typescript - for ingest-ui
  • nice looking error report - 1st step is the text output of the linter

possible tools:

  • super linter - will be used for 1st iteration, integrated as a github action
  • code climate - seems we used it slightly in the past
@ESapenaVentura
Copy link

@amnonkhen to merge this today

@aaclan-ebi aaclan-ebi changed the title code linting as a PR qulity check code linting as a PR quality check Apr 5, 2022
@jacobwindsor
Copy link

@amnonkhen why is this still in waiting?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants