Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review of GSE129605 prior to export #114

Closed
ESapenaVentura opened this issue Aug 13, 2020 · 1 comment
Closed

Review of GSE129605 prior to export #114

ESapenaVentura opened this issue Aug 13, 2020 · 1 comment
Assignees
Labels
broker to:SCEA This dataset needs to go to SCEA dataset All dataset tickets should have this label, only one ticket per dataset
Milestone

Comments

@ESapenaVentura
Copy link
Collaborator

Following from this issue https://github.com/HumanCellAtlas/hca-data-wrangling/issues/444

I am reviewing the datasets prior to submission and consideration for DCP2.

Review

Project - Contributors:

  • Added Ami's institution, laboratory, corresponding contributor and project role fields.
  • Added no to most contributors for corresponding contributor field and added one more yes. This info was extracted from the author's disclosure in the supplementary material for the paper.

Donor organism:

  • Added "Purchased from Taconic" at the end of the description.
  • Added "Medication" and "Treatment" fields to reflect the treatment the mice were given prior to extraction of the lungs.

Collection protocol:

  • Changed the description to include the full procedure (indicated in the supplementary material)
  • Changed the method to "Collecting specimen from organism postmortem"

Specimen from organism:

  • Changed the id for all specimens from the accession number to the name indicated on the right. Also added a final "s" to indicate both lungs were extracted.
  • Deleted BioSamples and INSDC sample accession. Looking at them it feels like they refer to the cell suspension, not the specimen.

Dissociation protocol:

  • Completely changed the descriptio, deleted the copies and changed the ID to generic. It felt like one copy for each condition was created, but the dissociation protocol was the same no matter the experimental condition. The new description can be found under the subsection "single cell isolation" in the supplementary materials

Enrichment protocol:

  • Added 2 enrichment protocols (And the tab itself). There was an enzymatic red blood cell removal (for which I couldn't find a good ontology term so for now I just left it as "enrichment protocol") and a dead cell removal protocol using MACS.

Cell suspension:

  • Changed the IDs of all the suspensions, it's not wrong but I don't like to use accessions as IDs
  • Added the INSDC sample accessions and re-matched the BioSamples accessions (They weren't matching the actual cell suspensions)
  • Added the enrichment protocol linkings and the dissociation protocol id change.

Library preparation protocol:

  • Changed the method to reflect the more accurate ontology (10x 3' v2 sequencing)
  • Changed end bias from 3 prime end bias to 3 prime tag

Sequence file:

  • Changed the process.process_core.process_id to match the library prep ID (Not necessary, just that I prefer them to match)

Notes

The new spreadsheet is under the same folder, but with the "_ES_review" suffix in the name.

@ESapenaVentura ESapenaVentura added dataset All dataset tickets should have this label, only one ticket per dataset operations This issue is an operational task labels Aug 13, 2020
@ESapenaVentura ESapenaVentura self-assigned this Aug 13, 2020
@lauraclarke lauraclarke removed the operations This issue is an operational task label Nov 4, 2020
@ESapenaVentura ESapenaVentura reopened this Nov 6, 2020
@ESapenaVentura ESapenaVentura added the broker to:SCEA This dataset needs to go to SCEA label Nov 6, 2020
@mshadbolt mshadbolt added this to the DCP2 MVP milestone Nov 10, 2020
@ami-day ami-day self-assigned this Apr 15, 2021
@ami-day
Copy link
Contributor

ami-day commented Apr 15, 2021

This one has already been handed over to scea a while ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
broker to:SCEA This dataset needs to go to SCEA dataset All dataset tickets should have this label, only one ticket per dataset
Projects
None yet
Development

No branches or pull requests

6 participants