Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using @for loop will generate styles w/out component namespacing #216

Closed
bttf opened this issue Feb 23, 2017 · 5 comments · Fixed by #217
Closed

Using @for loop will generate styles w/out component namespacing #216

bttf opened this issue Feb 23, 2017 · 5 comments · Fixed by #217

Comments

@bttf
Copy link

bttf commented Feb 23, 2017

With this in styles.scss:

@for $i from 1 through 3 {
  &.column-#{$i} {
    @include column($i, 7, 0);

    display: flex;
    flex-direction: column;
  }
}

Styles that are generated do not have component namespacing (order-confirmation):

screenshot_2017-02-23_10 05 32_360

Workaround so far is to include @for loop inside of parent selector

@webark
Copy link
Owner

webark commented Feb 23, 2017

@bttf didn't know you could do a for loop.. umm.. is that a bad work around..? We currently only ignore media and supports @ rules. https://github.com/topaxi/postcss-selector-namespace/blob/master/lib/plugin.js#L74 But maybe we should add for to the list of @ rules that get ignored.

@webark
Copy link
Owner

webark commented Feb 24, 2017

@topaxi what do you think about ignoring the @for rule also? Or what about getting to override the list also?

@topaxi
Copy link
Collaborator

topaxi commented Feb 24, 2017

@webark released as postcss-selector-namespace@1.3.0 👍

@webark
Copy link
Owner

webark commented Feb 24, 2017

@topaxi you are a gentleman and a scholar sir! Thanks for you quick turn around.

@webark
Copy link
Owner

webark commented Feb 24, 2017

@bttf version v0.2.12 has been released. I added an acceptance test to ensure that the functionality remains.

webark added a commit that referenced this issue Nov 2, 2017
# Change Log

All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.

<a name="0.3.7"></a>
## [0.3.7](v0.3.6...v0.3.7) (2017-11-02)


### Features

* **manifest ordering:** updated broccoli style manifest to now have the order of files in the manifest be sorted first by depth, then by alphanumeric ([fd710bf](fd710bf))



<a name="0.3.6"></a>
## [0.3.6](v0.3.5...v0.3.6) (2017-11-01)



<a name="0.3.5"></a>
## [0.3.5](v0.3.4...v0.3.5) (2017-07-31)


### Bug Fixes

* **component name parsing:** only switching out the word 'component/' if it is what starts the path, not for nest options. This should be revisited with unification Closes [#236](#236) ([54e087e](54e087e))



<a name="0.3.4"></a>
## [0.3.4](v0.3.3...v0.3.4) (2017-06-01)


### Bug Fixes

* **ensure environment:** getting the 'root host', and using a shim if the find host method isn't present, Closes [#231](#231) ([09fa5ec](09fa5ec))



<a name="0.3.3"></a>
## [0.3.3](v0.3.2...v0.3.3) (2017-04-24)



<a name="0.3.2"></a>
## [0.3.2](v0.3.1...v0.3.2) (2017-04-05)


### Bug Fixes

* **style manifest:** updated to new brocoli-style-mainifest properties that are more explicit ([5e848ca](5e848ca))


### Features

* **optimization:** ability to use terse class names to reduce css size ([d53ead8](d53ead8))



<a name="0.3.1"></a>
## [0.3.1](v0.3.0...v0.3.1) (2017-03-30)


### Bug Fixes

* **npm dependencies:** published what was being used to compile multiple differnt css preprocessors into one. closes [#221](#221) ([a060942](a060942))



<a name="0.3.0"></a>
# [0.3.0](v0.2.12...v0.3.0) (2017-02-25)


### Features

* **extensible identifier:** moved the generation of the namespace identifier and if the class should be added to a mixin for easier extensibility ([e3c627b](e3c627b))



<a name="0.2.12"></a>
## [0.2.12](v0.2.11...v0.2.12) (2017-02-24)


### Bug Fixes

* **description:** removed pod specificity ([16eae3b](16eae3b))
* **scss @ rules:** now allowing namespaceing of rules deinfed inside of a scss @ for rule. Fixes [#216](#216) ([6840c5e](6840c5e))



<a name="0.2.11"></a>
## [0.2.11](v0.2.10...v0.2.11) (2017-02-03)


### Bug Fixes

* **documentation:** updated for readabitlity ([d354534](d354534))



<a name="0.2.10"></a>
## [0.2.10](v0.2.9...v0.2.10) (2017-01-26)


### Bug Fixes

* **plain css:** Due to the odd nature of 'glob', you can't have a set of just one item. ([fd0d770](fd0d770)), closes [#178](#178) [#204](#204)



<a name="0.2.9"></a>
## [0.2.9](v0.2.8...v0.2.9) (2017-01-16)


### Bug Fixes

* **nested addons:** no longer switching to the parent app so that addon's specific settings can be used ([849a72d](849a72d))



<a name="0.2.8"></a>
## [0.2.8](v0.2.7...v0.2.8) (2016-12-14)



<a name="0.2.7"></a>
## [0.2.7](v0.2.6...v0.2.7) (2016-12-01)


### Bug Fixes

* **namespacing:** no longer namespacing children of @ rules ([489f23f](489f23f)), closes [#191](#191)



<a name="0.2.6"></a>
## [0.2.6](v0.2.5...v0.2.6) (2016-12-01)


### Bug Fixes

* **ember-2.11:** moving to concatenating and reassigning the classnames in case a classname is already in the array before the init call per [@rwjblue](https://github.com/rwjblue) suggestion ([40113e6](40113e6))



<a name="0.2.5"></a>
## [0.2.5](v0.2.4...v0.2.5) (2016-12-01)


### Bug Fixes

* **ember-2.11:** now not pushing to the frozen classnames property, but reasigning it ([63274c0](63274c0))



<a name="0.2.4"></a>
## [0.2.4](v0.2.3...v0.2.4) (2016-11-22)



<a name="0.2.3"></a>
## [0.2.3](v0.2.2...v0.2.3) (2016-11-15)



<a name="0.2.2"></a>
## [0.2.2](v0.2.1...v0.2.2) (2016-11-05)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants