Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support wallet connect 2 in the Taquito test dapp #2146

Closed
6 of 11 tasks
roxaneletourneau opened this issue Nov 23, 2022 · 0 comments · Fixed by #3045 · May be fixed by #2059
Closed
6 of 11 tasks

Support wallet connect 2 in the Taquito test dapp #2146

roxaneletourneau opened this issue Nov 23, 2022 · 0 comments · Fixed by #3045 · May be fixed by #2059
Assignees
Milestone

Comments

@roxaneletourneau
Copy link
Collaborator

roxaneletourneau commented Nov 23, 2022

Is your feature request related to a problem and use case? Please describe.
Allow users to connect through beacon or wallet connect on the test dapp.

Describe the solution you'd like

  • Add a button to connect to a wallet using wc2 and the WalletConnect2 class from Taquito
  • wc2 allows to connect to multiple accounts; show all connected accounts; the user should be able to switch between them in the dapp
  • Allow connecting using an existing pairing
  • Should we add an option to connect through an existing session?
  • Test the behavior on session expiry (NOTE: a session expires after seven days. It is not possible to lower the expiry time. See this Q&A)
  • Use Ecad Waku node by default in the dapp and add an option to use wc cloud service with a project id.
  • When we are on the test page of the dapp and reload it, we are brought back to the home page, the connection to the wallet is lost, and we need to connect again. See if we can stay on the same page without connecting the wallet again. The last active session should be used.
  • Handle session request expiration; if the connection was never approved on the wallet side
  • Handle wallet deleted session. If the session is deleted in the wallet, the dapp should listen for the event and reset the dapp state, clean up from user session (for example, go back to the connect wallet page)
  • Handle wallet updated session; integrate the updated session state into the dapp state. Accounts might have changed; call walletConnect2.getAccounts and update the state of the app (selected account, available accounts, balance, )
  • Add a ping button?
@roxaneletourneau roxaneletourneau self-assigned this Nov 23, 2022
@Innkst Innkst added this to the v15 milestone Nov 25, 2022
@Innkst Innkst added the wallet label Nov 25, 2022
@roxaneletourneau roxaneletourneau modified the milestones: v15, v15.1 Dec 7, 2022
@Innkst Innkst modified the milestones: v15.1, v16.1 Jan 11, 2023
@Innkst Innkst assigned ac10n and unassigned roxaneletourneau Apr 5, 2023
@Innkst Innkst modified the milestones: v16.1, v16.2 Apr 11, 2023
@Innkst Innkst modified the milestones: v16.2, v17.2 Jun 1, 2023
@Innkst Innkst modified the milestones: v17.2, v17.3 Jul 13, 2023
@Innkst Innkst modified the milestones: v17.2, v17.3, v18.1 Aug 15, 2023
@Innkst Innkst modified the milestones: v18.1, v17.4 Oct 2, 2023
@Innkst Innkst added the blocked Work is blocked for some reason label Jan 5, 2024
@hui-an-yang hui-an-yang modified the milestones: v19.1, v20+ Mar 7, 2024
@ac10n ac10n moved this to To do in Taquito Dev Jun 21, 2024
@hui-an-yang hui-an-yang modified the milestones: v20+, 21 Oct 2, 2024
@hui-an-yang hui-an-yang moved this from To do to In progress in Taquito Dev Oct 2, 2024
@hui-an-yang hui-an-yang assigned hui-an-yang and unassigned ac10n Oct 2, 2024
@hui-an-yang hui-an-yang removed the blocked Work is blocked for some reason label Oct 2, 2024
@hui-an-yang hui-an-yang linked a pull request Oct 2, 2024 that will close this issue
9 tasks
@hui-an-yang hui-an-yang modified the milestones: 21, v21, v20.1 Oct 2, 2024
@hui-an-yang hui-an-yang modified the milestones: v20.1, NEXT Nov 7, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Taquito Dev Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment