Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Paris] Remove RPC endpoint getEndorsingRights #2884

Closed
4 tasks done
hui-an-yang opened this issue Mar 20, 2024 · 0 comments · Fixed by #2916
Closed
4 tasks done

[Paris] Remove RPC endpoint getEndorsingRights #2884

hui-an-yang opened this issue Mar 20, 2024 · 0 comments · Fixed by #2916
Assignees
Milestone

Comments

@hui-an-yang
Copy link
Collaborator

hui-an-yang commented Mar 20, 2024

Attestation is now the default for operations encoding. (MR !11861)
Breaking change Removed the deprecated endorsing_rights RPC, use attestation_rights instead. (MR !11952)

Taquito supports both attestations and endorsement related operations on the RPC and forger level.
Taquito RPC type and local-forger support for consensus_operations like Attestation and Endorsement
The work in PR#2599 defaults the local forger to process attestations instead of endorsements.
Protocol P removes the RPC endpoint getEndorsingRights, on that note:

  • Remove RpcClient, RpcClientCache, RpcClientInterface, and rpcWrapperContractsLibrarysupport ofgetEndorsingRights`
  • Remove RPC request and response types for getEndorsingRights
  • Remove documentation and tests referencing getEndorsingRights

Bump RPCs GET ../mempool/monitor_operations, POST ../helpers/preapply/operations, GET ../blocks/, GET ../blocks//metadata. and GET ../blocks//operations default version to version 1. Version 0 can still be used with ?version=0 argument. (MR !11872)
Bump RPCs POST ../helpers/parse/operations, POST ../helpers/scripts/run_operation and POST ../helpers/scripts/simulate_operation default version to version 1. Version 0 can still be used with ?version=0 argument. (MR !11889)

  • double-check the rpc-client support of POST ../helpers/preapply/operations, GET ../blocks/<block>, GET ../blocks/<blocks>/metadata, POST ../helpers/scripts/run_operation and POST ../helpers/scripts/simulate_operation to default to version 1 and also if it's description need an update to default version 1
@hui-an-yang hui-an-yang added this to the v20 milestone Mar 20, 2024
@hui-an-yang hui-an-yang changed the title [Paris] default to Attestation instead of Endorsement [Paris] removed rpc endpoint - getEndorsingRights Mar 20, 2024
@dsawali dsawali changed the title [Paris] removed rpc endpoint - getEndorsingRights [Paris] Remove RPC endpoint getEndorsingRights Mar 21, 2024
@hui-an-yang hui-an-yang self-assigned this Apr 12, 2024
@hui-an-yang hui-an-yang linked a pull request Apr 15, 2024 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant