Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update remaining Taquito references of getActiveAccount() #2958

Closed
dsawali opened this issue May 10, 2024 · 0 comments · Fixed by #2960
Closed

Update remaining Taquito references of getActiveAccount() #2958

dsawali opened this issue May 10, 2024 · 0 comments · Fixed by #2960

Comments

@dsawali
Copy link
Contributor

dsawali commented May 10, 2024

Since Beacon v4.2.0, getActiveAccount() needs to be replaced by the event subscription as stated in Beacon's migration guide:
https://docs.walletbeacon.io/guides/migration-guide/

In a previous conversation, we have determined together in a video call with Beacon some time ago that Taquito's internal usage of getActiveAccount() to not be intrusive since it's only been used for 'validation' checks when trying to send operations to the wallet. For example: https://github.com/ecadlabs/taquito/blob/master/packages/taquito-beacon-wallet/src/taquito-beacon-wallet.ts#L62

However, for the sake of consistency and reliability, we should update Taquito's Beacon wallet implementation to match the recommended usage from Beacon. That is to use the ACTIVE_ACCOUNT_SET event using the eventSubscribe method instead of getActiveAccount()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants