Keep track of when and who last set the isShared flag

Author: carlobeltrame

api/migrations/schema/Version20250903125914.php

@@ -0,0 +1,33 @@
+<?php
+
+declare(strict_types=1);
+
+namespace DoctrineMigrations;
+
+use Doctrine\DBAL\Schema\Schema;
+use Doctrine\Migrations\AbstractMigration;
+
+/**
+ * Auto-generated Migration: Please modify to your needs!
+ */
+final class Version20250903125914 extends AbstractMigration {
+    public function getDescription(): string {
+        return 'Add sharedSince and sharedBy to camp';
+    }
+
+    public function up(Schema $schema): void {
+        // this up() migration is auto-generated, please modify it to your needs
+        $this->addSql('ALTER TABLE camp ADD sharedSince TIMESTAMP(0) WITHOUT TIME ZONE DEFAULT NULL');
+        $this->addSql('ALTER TABLE camp ADD sharedById VARCHAR(16) DEFAULT NULL');
+        $this->addSql('ALTER TABLE camp ADD CONSTRAINT FK_C19442304B2BC976 FOREIGN KEY (sharedById) REFERENCES "user" (id) NOT DEFERRABLE');
+        $this->addSql('CREATE INDEX IDX_C19442304B2BC976 ON camp (sharedById)');
+    }
+
+    public function down(Schema $schema): void {
+        // this down() migration is auto-generated, please modify it to your needs
+        $this->addSql('ALTER TABLE camp DROP CONSTRAINT FK_C19442304B2BC976');
+        $this->addSql('DROP INDEX IDX_C19442304B2BC976');
+        $this->addSql('ALTER TABLE camp DROP sharedSince');
+        $this->addSql('ALTER TABLE camp DROP sharedById');
+    }
+}

api/src/Entity/Camp.php

@@ -16,6 +16,7 @@
 use App\Serializer\Normalizer\RelatedCollectionLink;
 use App\State\CampCreateProcessor;
 use App\State\CampRemoveProcessor;
+use App\State\CampUpdateProcessor;
 use App\Util\EntityMap;
 use App\Validator\AssertContainsAtLeastOneManager;
 use Doctrine\Common\Collections\ArrayCollection;
@@ -38,6 +39,7 @@
             normalizationContext: self::ITEM_NORMALIZATION_CONTEXT,
         ),
         new Patch(
+            processor: CampUpdateProcessor::class,
             security: 'is_granted("CAMP_MEMBER", object) or is_granted("CAMP_MANAGER", object)',
             denormalizationContext: ['groups' => ['write', 'update']],
             normalizationContext: self::ITEM_NORMALIZATION_CONTEXT,
@@ -196,6 +198,24 @@ class Camp extends BaseEntity implements BelongsToCampInterface, CopyFromPrototy
     #[ORM\Column(type: 'boolean', nullable: false, options: ['default' => false])]
     public bool $isShared = false;
 
+    /**
+     * Date and time when the camp was last set to be shared publicly.
+     */
+    #[ApiProperty(example: '2025-10-01T00:00:00+00:00', required: true, openapiContext: ['format' => 'date-time'])]
+    #[Groups(['read'])]
+    #[ORM\Column(type: 'datetime', nullable: true)]
+    public ?\DateTimeInterface $sharedSince = null;
+
+    /**
+     * The person who last set the camp to be shared publicly.
+     */
+    #[Assert\DisableAutoMapping]
+    #[ApiProperty(writable: false)]
+    #[Groups(['read'])]
+    #[ORM\ManyToOne(targetEntity: User::class)]
+    #[ORM\JoinColumn(nullable: true)]
+    public ?User $sharedBy = null;
+
     /**
      * Whether this camp may serve as a template for creating other camps.
      */

api/src/State/CampUpdateProcessor.php

@@ -0,0 +1,41 @@
+<?php
+
+namespace App\State;
+
+use ApiPlatform\State\ProcessorInterface;
+use App\Entity\Camp;
+use App\Entity\CampCollaboration;
+use App\State\Util\AbstractPersistProcessor;
+use App\State\Util\PropertyChangeListener;
+use Symfony\Bundle\SecurityBundle\Security;
+
+/**
+ * @template-extends AbstractPersistProcessor<CampCollaboration>
+ */
+class CampUpdateProcessor extends AbstractPersistProcessor {
+    public function __construct(
+        ProcessorInterface $decorated,
+        private Security $security,
+    ) {
+        $sharingChangeListener = PropertyChangeListener::of(
+            extractProperty: fn (Camp $data) => $data->isShared,
+            beforeAction: fn (Camp $data) => $this->onBeforeStatusChange($data),
+        );
+
+        parent::__construct(
+            $decorated,
+            propertyChangeListeners: [
+                $sharingChangeListener,
+            ]
+        );
+    }
+
+    public function onBeforeStatusChange(Camp $data): Camp {
+        if (true == $data->isShared) {
+            $data->sharedSince = new \DateTime();
+            $data->sharedBy = $this->security->getUser();
+        }
+
+        return $data;
+    }
+}

common/helpers/dateHelperUTCFormatted.js

@@ -8,6 +8,10 @@ function dateLong(dateTimeString, tc) {
   return dayjs.utc(dateTimeString).format(tc('global.datetime.dateLong'))
 }
 
+function dateTimeLong(dateTimeString, tc) {
+  return dayjs.utc(dateTimeString).format(tc('global.datetime.dateTimeLong'))
+}
+
 function hourShort(dateTimeString, tc) {
   return dayjs.utc(dateTimeString).format(tc('global.datetime.hourShort'))
 }
@@ -101,6 +105,7 @@ function dateRange(start, end, tc) {
 export {
   dateShort,
   dateLong,
+  dateTimeLong,
   timeDurationShort,
   hourShort,
   hourLong,

common/helpers/userDisplayName.js

@@ -2,5 +2,5 @@
  * Returns a display name for a user
  */
 export default function (user) {
-  return user.displayName || ''
+  return user?.displayName || ''
 }

frontend/src/components/campAdmin/CampSharingSettings.vue

@@ -24,6 +24,12 @@
               }}</router-link>
             </template>
           </i18n>
+          <v-list-item-subtitle v-if="camp.isShared" class="pb-1">{{
+            $tc('components.campAdmin.campSharingSettings.sharedSince', 1, {
+              sharedSince: dateTimeLong(camp.sharedSince),
+              sharedBy: userDisplayName(camp.sharedBy()),
+            })
+          }}</v-list-item-subtitle>
         </v-list-item-content>
         <v-list-item-action v-if="camp.isShared" class="align-self-start">
           <v-tooltip top>
@@ -61,6 +67,8 @@ import ContentGroup from '@/components/layout/ContentGroup.vue'
 import ApiForm from '../form/api/ApiForm.vue'
 import router, { adminRoute, campRoute } from '@/router.js'
 import { campRoleMixin } from '@/mixins/campRoleMixin.js'
+import userDisplayName from '@/common/helpers/userDisplayName.js'
+import { dateTimeLong } from '@/common/helpers/dateHelperUTCFormatted.js'
 
 export default {
   name: 'CampSharingSettings',
@@ -85,6 +93,10 @@ export default {
     },
   },
   methods: {
+    userDisplayName,
+    dateTimeLong(dateTimeString) {
+      return dateTimeLong(dateTimeString, this.$tc.bind(this))
+    },
     async copyCampUrlToClipboard() {
       await navigator.clipboard.writeText(this.campUrl)
 

frontend/src/locales/de.json

@@ -136,6 +136,7 @@
           "description": "Alle Personen, die den Link zum Lager kennen, können das Programm, das Team, die Materiallisten und Verantwortlichkeiten und alles andere in diesem Lager ansehen. Nur Personen im {team} können Daten ändern.",
           "title": "Lager ist öffentlich freigegeben"
         },
+        "sharedSince": "Zuletzt freigegeben am {sharedSince} von {sharedBy}",
         "team": "Team",
         "title": "Lager teilen"
       },

frontend/src/locales/en.json

@@ -136,6 +136,7 @@
           "description": "All people who know the link to the camp can see the programme, team, material lists, responsibilities and all other data in this camp. Only people in the {team} can change data.",
           "title": "Camp is shared publicly"
         },
+        "sharedSince": "Currently shared since {sharedSince} by {sharedBy}",
         "team": "team",
         "title": "Sharing settings"
       },