Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problen when working on devices with mouse and touch screen #38

Closed
dape48 opened this issue Jan 14, 2016 · 1 comment
Closed

Problen when working on devices with mouse and touch screen #38

dape48 opened this issue Jan 14, 2016 · 1 comment

Comments

@dape48
Copy link

dape48 commented Jan 14, 2016

  • The directive don't registers handlers for mouse events on touch screen devices, only for touch events, neither for wheel, mouseenter, mouseleave and keydown events. Therefore you can't use mouse wheel (or touchpad on labtops) to scroll when using touch screens.
  • When the ng-scrollable component contains clickable components they will work clicking with mouse on it but not touchin because the touchstart event is prevented.

I have been trying to solve this isues, and it seems to work properly. Firstly I changed 'registerHandlers'/'unregisterHandlers' functions to always register/unregister handlers for wheel, mouseenter, mouseleave and keydown events. Then I changed 'onMouseDownX'/'onMouseDownY' functions to dont' prevent touchstart events.

Thanks!!

@echa
Copy link
Owner

echa commented Mar 27, 2016

Hey Dape48, thanks for reporting. Please try the new release 0.2.4. Hope this works for you now.

@echa echa closed this as completed Mar 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants