feat: Heroku updates: #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Now supports - adds procfile creation - adds .nvmrc - fixes typo in package.json - updates package.json conditionals (removes server-express) - fixes named export bug in test/helpers.ts
mthomps4
force-pushed
the
mt-heroku-setup-pt-1
branch
from
69d55b8
to
ed1144d
Compare
cball
approved these changes
May 10, 2021
| @@ -66,6 +66,8 @@ module.exports = async ({ name, ...answers }) => { | |||
| variables.host.createAppsAndPipelines, | |||
| task: async () => { | |||
| const repoName = variables.githubRepo.match(/(\w+\/\w+).git$/)[1]; | |||
| // ! Bug w/ Pipelines, better error handling needed. | |||
| // await fsPromises.writeFile("Procfile", "web: yarn db:deploy && yarn start"); | |||
There was a problem hiding this comment.
Should we add a follow up issue to track this?
There was a problem hiding this comment.
I'll get this added as a follow-up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Heroku updates:
apollo-server-microoverapollo-server-expressNode Version:
Checklist