Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: login and signup component unit tests #165

Merged
merged 1 commit into from
Jun 18, 2021
Merged

fix: login and signup component unit tests #165

merged 1 commit into from
Jun 18, 2021

Conversation

kgajera
Copy link
Contributor

@kgajera kgajera commented Jun 18, 2021

This fixes the login and signup component unit tests.

Changes

The tests were failing because:

  • The prefetch function on our mock router needed to return a promise
  • The @testing-library dependencies required updating

Checklist

  • Requires dependency update?
  • Generating a new app works

code-jenn-or
code-jenn-or suggested changes Jun 18, 2021
View reviewed changes
Copy link
Contributor

@code-jenn-or code-jenn-or left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome!
Given the other PR was merged that skipped those tests we will want to make sure we rebase from canary before we merge this but can't wait to have all the tests working again.

packages/create-bison-app/template/tests/utils.tsx
beforePopState: jest.fn(),
prefetch: jest.fn(() => Promise.resolve()),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@kgajera kgajera force-pushed the fix-login-and-signup-tests branch from 55f5353 to a6b7b4f Compare June 18, 2021 13:41
@kgajera
Copy link
Contributor Author

kgajera commented Jun 18, 2021

I just rebased the PR and updated the tests to not be skipped.

Screen Shot 2021-06-18 at 9 40 35 AM

code-jenn-or
code-jenn-or approved these changes Jun 18, 2021
View reviewed changes
Copy link
Contributor

@code-jenn-or code-jenn-or left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
🎉

@code-jenn-or code-jenn-or merged commit be40238 into canary Jun 18, 2021
@code-jenn-or code-jenn-or deleted the fix-login-and-signup-tests branch June 18, 2021 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@code-jenn-or code-jenn-or code-jenn-or approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kgajera @code-jenn-or