feat: Enable TS strict #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgajera
requested changes
Jan 7, 2022
| @@ -51,9 +51,14 @@ export function LoginForm() { | |||
| try { | |||
| setIsLoading(true); | |||
| const { data } = await login({ variables: formData }); | |||
|
|
|||
| if (!data?.login?.token) { | |||
| throw new Error('Login failed.'); | |||
There was a problem hiding this comment.
It's probably out of the scope of this PR, but we should create another issue to display some kind of user feedback when this is error is thrown.
| @@ -65,10 +65,14 @@ export function SignupForm() { | |||
|
|
|||
| const { data } = await signup({ variables }); | |||
|
|
|||
| if (!data?.signup?.token) { | |||
| throw new Error('Signpup failed.'); | |||
There was a problem hiding this comment.
Typo: "Signpup" should be "Signup"
| .findUnique({ | ||
| where: { id: parent.id }, | ||
| }) | ||
| .user(); | ||
|
|
||
| if (!user) { | ||
| throw new ApolloError('User not found', '404'); |
There was a problem hiding this comment.
I would recommend creating a custom error, like NotFoundError, for this because we will need to use this frequently in real apps and we don't want to have to repeat the error code each time.
Just my opinion, but I would also favor using NOT_FOUND as the error code because Apollo doesn't use HTTP response codes for their built-in errors.
kgajera
approved these changes
Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Checklist