Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace queryType with extendType #65

Merged
merged 1 commit into from
Sep 30, 2020

Conversation

alvincrespo
Copy link
Contributor

Nexus will error out if a previous queryType is already defined. We're planning to include a "global" that sets this - so ensuring that generated modules just extend Query will ensure this error does not happen for a dev.

Changes

  • Replaces queryType in our generated template with extendType

Checklist

  • Requires dependency update?
  • Generating a new app works

Nexus will error out if a previous queryType is already defined. We're
planning to include a "global" that sets this - so ensuring that
generated modules just extend Query will ensure this error does not
happen for a dev.
@alvincrespo alvincrespo added the bug Something isn't working label Sep 30, 2020
@alvincrespo alvincrespo self-assigned this Sep 30, 2020
@@ -27,7 +27,8 @@ export const CallPreference = enumType({
});

// Queries
schema.queryType({
schema.extendType({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸

@cball cball merged commit f6a6e46 into main Sep 30, 2020
@cball cball deleted the fix/replace-querytype-with-extendtype branch September 30, 2020 13:53
@github-actions
Copy link

🎉 This PR is included in version 1.6.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Issue has been included in a PR label Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released Issue has been included in a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants