Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove nexus build from build script #74

Merged
merged 2 commits into from
Oct 7, 2020
Merged

Conversation

cball
Copy link
Member

@cball cball commented Oct 7, 2020

This was missed in #68. Additionally, we needed a few additional build scripts to ensure a proper production build.

Changes

  • add nexus, next, and prisma build scripts to ensure a proper production build.

Screenshots

n/a

Checklist

  • Requires dependency update?
  • Generating a new app works

Fixes #72

@cball cball changed the base branch from canary to main October 7, 2020 19:07
Copy link

@mcavaliere mcavaliere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cball Generated an app from this release and it started successfully, but getting the following:

image

@cball
Copy link
Member Author

cball commented Oct 7, 2020

@mcavaliere looks like you might be using an older release? the build command should be https://github.com/echobind/bisonapp/pull/74/files#diff-399b2acbf24e192838a40ee0f8fe44e0R9

also the "get used plugins" line is from Nexus Framework, which we just converted to @nexus/schema.

@cball
Copy link
Member Author

cball commented Oct 7, 2020

reconfirmed locally as well.

@cball cball merged commit 069ffa0 into main Oct 7, 2020
@cball cball deleted the 72-fix-build-command branch October 7, 2020 20:45
github-actions bot pushed a commit that referenced this pull request Oct 7, 2020
## [1.7.2](v1.7.1...v1.7.2) (2020-10-07)

### Bug Fixes

* remove nexus build from build script ([#74](#74)) ([069ffa0](069ffa0))
@github-actions
Copy link

github-actions bot commented Oct 7, 2020

🎉 This PR is included in version 1.7.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Issue has been included in a PR label Oct 7, 2020
@mcavaliere
Copy link

@cball correct, I had to unlink and relink. New error when generating:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Issue has been included in a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

generated build command should not include nexus dev
3 participants