fix: ensure @nexus/schema config uses prettier config #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaiahgrey93
approved these changes
Oct 12, 2020
| notIn: [DateTime] | ||
| } | ||
|
|
||
| input NestedStringFilter { |
There was a problem hiding this comment.
Curious to why this exists being that there doesn't appear to be any difference from StringFilter as far as I can tell?
Maybe just semantics in the name?
Same thought on the other types with the Nested{Type} 🤔
There was a problem hiding this comment.
Good question. It looks like we forgot to re-run this during an upgrade. After all the open PRs are merged, I'll re-run and check the diff.
| @@ -114,6 +114,7 @@ | |||
| } | |||
| }, | |||
| "lint-staged": { | |||
| "*.{ts,tsx}": "yarn lint" | |||
| "*.{ts,tsx}": "yarn lint", | |||
| "*.{graphql}": "prettier --write" | |||
github-actions bot
pushed a commit
that referenced
this pull request
Oct 13, 2020
## [1.7.3-canary.2](v1.7.3-canary.1...v1.7.3-canary.2) (2020-10-13) ### Bug Fixes * lint error in dropDatabase broke codegen ([#80](#80)) ([ffa0528](ffa0528)) * ensure @nexus/schema config uses prettier config ([#79](#79)) ([f382cad](f382cad)) * remove whitespace from package.json ([#81](#81)) ([16e3edb](16e3edb))
|
🎉 This PR is included in version 1.7.3-canary.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 13, 2020
## [1.7.3](v1.7.2...v1.7.3) (2020-10-13) ### Bug Fixes * lint error in dropDatabase broke codegen ([#80](#80)) ([ffa0528](ffa0528)) * ensure @nexus/schema config uses prettier config ([#79](#79)) ([f382cad](f382cad)) * ensure dotfiles are copied. Extract copyFiles util and add tests. ([#83](#83)) ([8c070c8](8c070c8)) * fix prisma gen folder path, upgrade prisma client & nexus plugin ([#82](#82)) ([9c9d834](9c9d834)) * remove whitespace from package.json ([#81](#81)) ([16e3edb](16e3edb)) * **npm:** include utils folder in final package ([#71](#71)) ([a390256](a390256))
|
🎉 This PR is included in version 1.7.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures our generated schema runs through prettier. This also applies the graphql best practice of alphabetically sorting field names in the schema file.
Changes
api.graphqland and prettier.configlint-stagedas a fallbackScreenshots
n/a
Checklist
Fixes #77