Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove whitespace from package.json #81

Merged
merged 2 commits into from
Oct 12, 2020
Merged

fix: remove whitespace from package.json #81

merged 2 commits into from
Oct 12, 2020

Conversation

cball
Copy link
Member

@cball cball commented Oct 11, 2020

This was outputting blank lines in the package.json, which we don't want. this PR fixes it.

Changes

  • Clean up package.json template

Screenshots

n/a

Checklist

  • Requires dependency update?
  • Generating a new app works

@cball cball requested a review from a team October 11, 2020 13:34
Copy link
Contributor

@isaiahgrey93 isaiahgrey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:slaps_roof_of_car:

Curious if there is any prettier support for .ejs?

@cball
Copy link
Member Author

cball commented Oct 12, 2020

Not that I know of. Especially since whitespace is significant.

One thing we could do is run prettier on the outputted file and make sure there are no changes?

@cball cball merged commit 16e3edb into canary Oct 12, 2020
@cball cball deleted the ejs-whitespace branch October 12, 2020 23:56
github-actions bot pushed a commit that referenced this pull request Oct 13, 2020
## [1.7.3-canary.2](v1.7.3-canary.1...v1.7.3-canary.2) (2020-10-13)

### Bug Fixes

*  lint error in dropDatabase  broke codegen ([#80](#80)) ([ffa0528](ffa0528))
* ensure @nexus/schema config uses prettier config ([#79](#79)) ([f382cad](f382cad))
* remove whitespace from package.json ([#81](#81)) ([16e3edb](16e3edb))
@github-actions
Copy link

🎉 This PR is included in version 1.7.3-canary.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Oct 13, 2020
## [1.7.3](v1.7.2...v1.7.3) (2020-10-13)

### Bug Fixes

*  lint error in dropDatabase  broke codegen ([#80](#80)) ([ffa0528](ffa0528))
* ensure @nexus/schema config uses prettier config ([#79](#79)) ([f382cad](f382cad))
* ensure dotfiles are copied. Extract copyFiles util and add tests. ([#83](#83)) ([8c070c8](8c070c8))
* fix prisma gen folder path, upgrade prisma client & nexus plugin ([#82](#82)) ([9c9d834](9c9d834))
* remove whitespace from package.json ([#81](#81)) ([16e3edb](16e3edb))
* **npm:** include utils folder in final package ([#71](#71)) ([a390256](a390256))
@github-actions
Copy link

🎉 This PR is included in version 1.7.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Issue has been included in a PR label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @canary released Issue has been included in a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants