Skip to content
This repository was archived by the owner on Mar 8, 2023. It is now read-only.

Use file_line instead shellvar #60

Closed
jkroepke opened this issue Jan 15, 2016 · 5 comments
Closed

Use file_line instead shellvar #60

jkroepke opened this issue Jan 15, 2016 · 5 comments
Assignees

Comments

@jkroepke
Copy link

Hi!

first, thank for all your work. This module help me a lot on my work.

I want to ask, If it is possible to replace augeas shellvar function with stdlib's file_line.
Currently, the augeasproviders_core and augeasproviders_shellvar modules are not very active and augeasproviders_core do not have offical puppet4 support.

Also puppetlabs inifile module would be an option, too.

What did you think about this?

@dwerder dwerder self-assigned this Jan 15, 2016
@dwerder
Copy link
Member

dwerder commented Jan 15, 2016

To use file_line we have first to bump the stdlib version of this module. At the moment its 3.2.0. And it should at least be 4.4.0 (better 4.8.0), because of bugfixes in file_line function for older ruby and puppet. But that should be possible.

Also we need to bump supported puppet version. At the moment we "support" 2.7+ . That should be changed to 3.0 (better >3.3)

Do you want to provide a patch? If so read DEVELOP.md

@jkroepke
Copy link
Author

Hi,

yes I can provide a patch.

Before I start I just wanted to ask if this is intentional.

@dwerder
Copy link
Member

dwerder commented Jan 15, 2016

Its always a good idea to have less dependencies. So go for it.

@jkroepke
Copy link
Author

So its okay right now?

@dwerder
Copy link
Member

dwerder commented Jan 18, 2016

Merged and closed ;-)

@dwerder dwerder closed this as completed Jan 18, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants