Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Serializer / Deserializer (AASX) should have some warning handler (instead of just logging) #112

Open
in-fke opened this issue May 12, 2023 · 1 comment
Labels
3.0 Final AAS V3 Final Release enhancement New feature or request

Comments

@in-fke
Copy link

in-fke commented May 12, 2023

This may not just apply to AASXSerializer / AASXDeserializer but to others as well (which should share a common interface).
Also, this may have some impact on all sorts of classes, e.g. ReflectionHelper.
IS:
ReflectionHelper et al issue logger WARN
Sould:
Caller should be able to pass some optional lambda (e.g. a consumer for warnings), to catch warnings programmatically.

Example output from (modified) routine similar to org.eclipse.digitaltwin.aas4j.v3.dataformat.aasx.serialization.AASXSerializerTest, but with 1.0.0-milestone-03 (main branch does not produce the first two warnings, and the last warning is due to the modification of our test).

[main] WARN org.eclipse.digitaltwin.aas4j.v3.dataformat.core.util.ReflectionHelper - could not auto-resolve target class for mixin 'DataSpecificationPhysicalUnitMixin'
[main] WARN org.eclipse.digitaltwin.aas4j.v3.dataformat.core.util.ReflectionHelper - could not auto-resolve target class for mixin 'LangStringMixin'
[main] WARN org.eclipse.digitaltwin.aas4j.v3.dataformat.aasx.AASXSerializer - Could not add File '/aasx/OperatingManual.pdf'. It was not contained in given InMemoryFiles.
@twebermartins twebermartins added the enhancement New feature or request label May 12, 2023
@twebermartins
Copy link
Contributor

Thanks for pointing this out! We will have a look at it.

@twebermartins twebermartins added the 3.0 Final AAS V3 Final Release label Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.0 Final AAS V3 Final Release enhancement New feature or request
Projects
Status: 🆕 New
Development

No branches or pull requests

2 participants