-
Notifications
You must be signed in to change notification settings - Fork 780
Order of XML elements should not matter #2408
Comments
I think the implementation is made this way, because of the thing-description-1.0.0.xsd. The sequence element assumes that an order is expected. |
This is correct. However, it's not that trivial to change the XSD accordingly, as the obvious choice ( |
I gave this another try. But as @SJKA already pointed out the Otherwise all types now provided in <thing-type id="myId">
<label>My Thing</label>
<thing:channels>
<channel id="switch" typeId="switch" />
</thing:channels>
<thing:config-description>
<parameter type="text" name="test">
</parameter>
</thing:config-description>
</thing-type> This way everything could stay in the same XML, the solution above is achieved using the Imho this is too much of an effort just to be order independent. My Suggestion is to label this issue as "Wont Fix" and reference it whenever needed. |
I agree that this is too much effort and also we would need to change all existing bindings because of the added namespace to the elements. Maybe if we have to break the API some day anyway we could think of it. But now just to ignore the order of elements it is IMHO not worth it. @SJKA @kaikreuzer Can you please clsoe this issue as @htreu suggested with "won't fix" label? |
I don't like it, but what is there to do... |
XML thing/channel types have a couple of properties that are declared in the XML as elements.
Currently, a certain order seems to be expected, this leads to problems like the one that required this patch in order to make the XML parsable. This is imho very unexpected and I do not really see a good reason why it has to be that way.
The text was updated successfully, but these errors were encountered: