Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Californium does not support standard coap codes for ping 7.02 and pong 7.03 #1564

Closed
joe-pulse opened this issue Mar 16, 2021 · 7 comments
Closed

Comments

@joe-pulse
Copy link

joe-pulse commented Mar 16, 2021

  • Tag: 2.6.1 (i.e. latest)
  • Protocol: TCP

Problem description

There seems no support in Californium for the ping/pong messages defined by CoAP RFC 8323:

Currently, if Calfornium receives a PING sent by another CoAP stack, DataParser.parseMessage throws an "illegal message code" exception.

Because code 7.02 lies outside REQUEST_CODE_LOWER_BOUND, REQUEST_CODE_UPPER_BOUND and RESPONSE_CODE_LOWER_BOUND, RESPONSE_CODE_UPPER_BOUND defined in californium.core.coap.CoAP.

This causes significant problems communicating with other CoAP stacks.

@boaks
Copy link
Contributor

boaks commented Mar 16, 2021

Yes, the TCP implementation RFC 8323 is still very experimental and more or less based on a early version of that RFC.

Do you have interest in evolving it?

My interest in CoAP over TCP is limited. See Next major version 3.0 - About CoAP over TCP / RFC 8323 and issue #1488.

@joe-pulse
Copy link
Author

Thanks for the reply. Sure, we have a fairly conservative fix that simply forwards the 7.02 pings to the application layer as Requests, and allows the application to handle them. Will submit a PR!

@boaks
Copy link
Contributor

boaks commented Mar 17, 2021

Please obey CONTRIBUTING.

You will mainly need a ECA, using the same e-mail address as used for "signing" the commit.

@boaks
Copy link
Contributor

boaks commented Mar 17, 2021

Just to ask:

Do you want to apply this for 2.6.x? If so, is it possible that you give us/me your planed time-schedule?

In order to sync with an upcoming leshan milestone release, I scheduled a 2.6.2 bugfix release for next Tuesday. If required, that could also be postponed for 1-2 days.

@boaks
Copy link
Contributor

boaks commented Mar 18, 2021

Uups, sorry, I was mislead.
Though that change will be an API extension, it requires a minor version. That would trigger a new review (our last is more than a year ago). So, please, only plan for 3.0 .

@boaks
Copy link
Contributor

boaks commented Mar 25, 2021

@joe-pulse

Any news on this?

@boaks
Copy link
Contributor

boaks commented Apr 8, 2021

@joe-pulse

Don't hesitate to create a PR, if you're still on this issue.

@boaks boaks closed this as completed Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants