Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not switch to maintenance mode during Jenkins safe restart #130

Open
fredg02 opened this issue Oct 30, 2020 · 2 comments
Open

Do not switch to maintenance mode during Jenkins safe restart #130

fredg02 opened this issue Oct 30, 2020 · 2 comments
Assignees
@mbarbero
Labels
enhancement New feature or request

Comments

@fredg02
Copy link
Contributor

fredg02 commented Oct 30, 2020

If there are issue during deployment, especially while waiting for a Jenkins instance to come online during/after a safe restart, it requires extra work to fix the routes, etc manually.
Since the benefit of "dropping the curtain" during a (in most cases) relatively short safe restart, I'd recommend that we only switch to maintenance mode on demand (e.g. if we work on a JIPP for a longer time and want to avoid interruptions).
@fredg02 fredg02 added the enhancement New feature or request label Oct 30, 2020
@mbarbero
Copy link
Member

The extra work to fix the routes etc should not be manual. I made the switch-maintenance script much more resilient, so a simple call to switch-maintenance.sh <instance> off should fix everything. Could you please double check that it works for you first?

@fredg02
Copy link
Contributor Author

fredg02 commented Oct 30, 2020

sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbarbero mbarbero

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mbarbero @fredg02