Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark maven plugins are being thread-safe #496

Closed
netomi opened this issue Jul 22, 2024 · 1 comment · Fixed by #497
Closed

Mark maven plugins are being thread-safe #496

netomi opened this issue Jul 22, 2024 · 1 comment · Fixed by #497

Comments

@netomi
Copy link
Contributor

netomi commented Jul 22, 2024

If the plugins are using in parallel builds, maven will issue a warning as it cannot determine if the plugings are thread-safe:

09:29:15  [WARNING] *****************************************************************
09:29:15  [WARNING] * Your build is requesting parallel execution, but this         *
09:29:15  [WARNING] * project contains the following plugin(s) that have goals not  *
09:29:15  [WARNING] * marked as thread-safe to support parallel execution.          *
09:29:15  [WARNING] * While this /may/ work fine, please look for plugin updates    *
09:29:15  [WARNING] * and/or request plugins be made thread-safe.                   *
09:29:15  [WARNING] * If reporting an issue, report it against the plugin in        *
09:29:15  [WARNING] * question, not against Apache Maven.                           *
09:29:15  [WARNING] *****************************************************************
09:29:15  [WARNING] The following plugins are not marked as thread-safe in eclipse-platform-parent:
09:29:15  [WARNING]   org.eclipse.cbi.maven.plugins:eclipse-jarsigner-plugin:1.4.3

Generally, all our plugins should be thread-safe (need to double check though) and we should add the threadsafe = true flag to the Mojo annotation.

@netomi
Copy link
Contributor Author

netomi commented Jul 22, 2024

The flatpak plugin is not threadsafe as it has an instance variable flatpakId that gets modified in the execute method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant