Recent changes make it impossible to extend the API

[thegecko]

The exported API here: https://github.com/eclipse-cdt-cloud/vscode-clangd/blob/main/src/extension.ts#L18

is an instance of a single ClangdProjectService class. Exposing this as the root API means it is not possible to expose other features without adding them to the ClangdProjectService itself, creating a very ugly interface.

For example, this PR: clangd#575 is exposing access to the AST and wont play nicely with the changes in this fork.

Could you consider changing the exports to be more extensible, possibly employing the same versioned API in the PR mentioned above?

[tortmayr]

Hi @thegecko

thanks for raising this. We are all in favor of adopting the exports to allow a more extensible API.
However, I would like to wait with this until clangd#575 is merged in the upstream project.

Then we can make the necessary changes in combination with an update to the latest upstream version.

[thegecko]

Lol, I was asked to move that PR to come from this fork, hence finding the clash!

If the PR isn't accepted, I'm keen for it to live here :)

[tortmayr]

Ah I wasn't aware that there already was an ongoing discussion about this.
In that case, we are happy to take this over and adapt your extension API to align it with the API mentioned in the PR.

[thegecko]

FYI, the API exposure PR has now been merged:

clangd#575

Can the additions in this repo be rebased accordingly?

[thegecko]

bump @tortmayr

[tortmayr]

@thegecko Thanks for pining. Our resources were rather limited the last couple of months, so I did not have time to tackle this yet.
I should be able to drive this forward until the end of this week.