Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-couple starting a trace server with opening a trace. #217

Open
williamsyang-work opened this issue Mar 11, 2024 · 0 comments
Open

De-couple starting a trace server with opening a trace. #217

williamsyang-work opened this issue Mar 11, 2024 · 0 comments

Comments

@williamsyang-work
Copy link
Contributor

williamsyang-work commented Mar 11, 2024

We currently cannot start a trace server without opening a trace. My understanding is that we want to search available TraceServerContributors for one where the trace being attempted to open is already available.

It would be simpler to have the functionality of opening a trace and starting a trace-server de-coupled. The functionality of starting a trace-server without the need of a file path would be invaluble.

My understanding and suggested solution:

Instead of having one current route for starting a server:

  1. Start Trace Server with mandatory file path

We could have three options:

  1. Start Trace Server with optional file path, searching available TraceServerContributors for one with the trace open (previous implementation).
  2. Start ANY trace server from ANY TraceServerContributor (if any)
  3. Open a trace with a current and available TraceServerContributor.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant