Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Clean up theia-endpoint-runtime directory structure #200

Closed
tsmaeder opened this issue May 2, 2019 · 5 comments
Closed

Clean up theia-endpoint-runtime directory structure #200

tsmaeder opened this issue May 2, 2019 · 5 comments
Assignees

Comments

@tsmaeder
Copy link
Contributor

tsmaeder commented May 2, 2019

The folder dockerfiles/theia-endpoint-generator contains actually 3 things:

  1. Docker stuff to build the theia endpoint runtime docker image
  2. A nodejs application that starts a version of theia that only runs a plugin endpoint (starting with plugin-remote.ts)
  3. A theia extension that handles discovery of locally installed plugins and routes messages to/from those plugins.

Having all those concerns mixed in the same directory structure makes it difficult to understand what is going on in the code and prevents us from separating generally useful code from the Che specific stuff.

We should do two things:

  1. Separate the plugin endpoint theia extension to extensions/plugin_endpoint
  2. Separate the nodejs application to it's own root level folder

Running plugins in multiple plugin host processes seems like something that we might even contribute back to the main theia project if we structure the code correctly.

@tsmaeder tsmaeder added the invalid This doesn't seem right label May 2, 2019
@tsmaeder
Copy link
Contributor Author

tsmaeder commented May 2, 2019

Adding label "invalid", because we don't have a label for "software architecture".

@AndrienkoAleksandr
Copy link
Contributor

AndrienkoAleksandr commented May 3, 2019

software architecture

Ok, I applied label "software architecture"

@benoitf benoitf added software architecture and removed invalid This doesn't seem right labels May 15, 2019
@benoitf
Copy link
Contributor

benoitf commented May 15, 2019

The remote extension was before a separate extension in a separate repository and @tolusha from your team moved it to docker folder part so it seems there is a lack of consistency in what you're describing.

AFAIK it was intentional to keep this extension part of Eclipse Che without putting it in Theia.

@tsmaeder
Copy link
Contributor Author

So I guess he moved it to the wrong directory.

AFAIK it was intentional to keep this extension part of Eclipse Che without putting it in Theia.

What was intentional? I don't object to this being in the che-theia repo, but to it being all in the same directory and in the "dockerfiles" dir.

@benoitf
Copy link
Contributor

benoitf commented May 15, 2019

@tsmaeder intentional to have this extension in che-theia and not theia.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants