Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support running Che 7 plugins and runtime in separate pods #11476

Closed
l0rd opened this issue Oct 4, 2018 · 8 comments
Closed

Support running Che 7 plugins and runtime in separate pods #11476

l0rd opened this issue Oct 4, 2018 · 8 comments
Labels
area/che-server engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@l0rd
Copy link
Contributor

l0rd commented Oct 4, 2018

Description

Currently in Kube and OpenShift infrastructure all Che 7 plugins, editors and runtime are spawned in one unique fat pod:

image

This was a limitation that we had to live with because all containers needed access to the same Persistent Volume and we needed to support RWO Persistent Volumes first.

But this configuration has many drawbacks:

  • ports collisions
  • cannot support deployment/deployment config based recipes configurations with more than one pod
  • cannot run short living sidecars
  • cannot restart plugins
  • cannot restart runtime

This epic is about supporting an alternative configuration with every container running in its own Pod:

image

This configuration should be the default when the workspace persistent volume is RWX.

@l0rd l0rd added kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. team/osio labels Oct 4, 2018
@garagatyi
Copy link

We can separate sidecars that do not declare the dependency on the projects' volume even now!
Apart from that, we can implement different strategies of volume content syncing. RWX is not supported everywhere, but we can add also use sync sidecar to emulate it.
I would start from separating non-volume dependent sidecars to separate pods.

@ibuziuk
Copy link
Member

ibuziuk commented Oct 23, 2018

@garagatyi @l0rd I have created an issue for supporting non-volume dependent sidecars as separate pods in rh-che [1]. Do you happen to have some ideas about other potential sub-tasks that we could add to the next sprint related to this epic ?

[1] redhat-developer/rh-che#1005

@l0rd
Copy link
Contributor Author

l0rd commented Oct 24, 2018

@ibuziuk the goal of these 2 issues is to run containers in distinct pods. But besides that they are not related (e.g one is a subtask of the other). Let me clarify:

As mentioned in a call we had today I would prioritize the work in this order:

  1. support fully ephemeral workspaces (che 7) Che plugin broker should support ephemeral mode redhat-developer/rh-che#987
  2. run containers that don't need access to the PV in a distinct Pod Che 7: Need to support running non-volume dependent sidecars as separate pods redhat-developer/rh-che#1005
  3. take advantage of RWX PR when available (this issue)

@che-bot
Copy link
Contributor

che-bot commented Sep 7, 2019

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 7, 2019
@che-bot che-bot closed this as completed Sep 17, 2019
@ibuziuk ibuziuk reopened this Nov 8, 2019
@ibuziuk
Copy link
Member

ibuziuk commented Nov 8, 2019

/remove-lifecycle stale

@che-bot
Copy link
Contributor

che-bot commented Jul 6, 2020

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 6, 2020
@l0rd
Copy link
Contributor Author

l0rd commented Jul 6, 2020

/remove-lifecycle stale

@benoitf benoitf added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 6, 2020
@l0rd l0rd added engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. area/che-server labels Jul 29, 2020
@l0rd
Copy link
Contributor Author

l0rd commented Sep 28, 2021

This issue is not current anymore. We are rather aiming to run all IDE services in the developer container.

@l0rd l0rd closed this as completed Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/che-server engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

6 participants