Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Theia Plugin APIs to support VS Code XML Tooling #11775

Closed
apupier opened this issue Oct 30, 2018 · 10 comments
Closed

Add Theia Plugin APIs to support VS Code XML Tooling #11775

apupier opened this issue Oct 30, 2018 · 10 comments
Assignees
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.

Comments

@apupier
Copy link
Contributor

apupier commented Oct 30, 2018

Description

Che is not providing XML support currently; it would be nice to reuse the VS Code xml work https://marketplace.visualstudio.com/items?itemName=redhat.vscode-xml

Reproduction Steps

currently it is failing with:

root ERROR [hosted-plugin: 211] (node:211) UnhandledPromiseRejectionWarning: SyntaxError: Unexpected token u in JSON at position 0
    at JSON.parse (<anonymous>)
    at getSettings (/tmp/vscode-unpacked/vscode_extension_redhat_vscode_xml.vsix/extension/out/src/extension.js:74:29)
    at requirements.resolveRequirements.catch.then.requirements (/tmp/vscode-unpacked/vscode_extension_redhat_vscode_xml.vsix/extension/out/src/extension.js:45:48)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:189:7)

the corresponding code is:

function getSettings() {
        let configXML = vscode_1.workspace.getConfiguration();
        configXML = configXML.get('xml');
        let x = JSON.stringify(configXML);
        let settings = JSON.parse(x);
        settings['logs']['file'] = logfile;
        return settings;
    }

Line 74 is the JSON.parse

OS and version:

Diagnostics:

@apupier apupier changed the title s Add Theia Plugin APIs to support VS Code XML Tooling Oct 30, 2018
@apupier
Copy link
Contributor Author

apupier commented Oct 30, 2018

current stack seems to be a Theia issue so reported eclipse-theia/theia#3317

@skabashnyuk skabashnyuk added the kind/question Questions that haven't been identified as being feature requests or bugs. label Nov 2, 2018
@skabashnyuk
Copy link
Contributor

@ashumilova @evidolob can you help here?

@benoitf benoitf self-assigned this Nov 2, 2018
@benoitf benoitf added kind/task Internal things, technical debt, and to-do tasks to be performed. and removed kind/question Questions that haven't been identified as being feature requests or bugs. labels Nov 2, 2018
@slemeur
Copy link
Contributor

slemeur commented Dec 11, 2018

@evidolob + @tsmaeder : Could you check the status of this issue regarding the progress on eclipse-theia/theia#2341 ?

@tsmaeder
Copy link
Contributor

@slemeur testing the xml plugin (and identifying missing/broken API is on our plan), however, there are two things you might not be aware of:

  1. Plugins use VSCode API beyond the "languages" namespace
  2. The "renameProvider" API is still missing. As far as I understand, the IDE2 team is tasked with completing [plug-in] Languages API eclipse-theia/theia#2341

@tsmaeder
Copy link
Contributor

Update: there seems to be a PR pending for the rename provider.

@benoitf
Copy link
Contributor

benoitf commented Jan 14, 2019

rename provider eclipse-theia/theia#4025 has been merged upstream

@slemeur slemeur mentioned this issue Feb 1, 2019
23 tasks
@tsmaeder tsmaeder mentioned this issue Feb 8, 2019
20 tasks
@apupier
Copy link
Contributor Author

apupier commented Apr 10, 2019

@benoitf @tsmaeder if I understand well, this has been done, right?
If yes, I will close the issue

@tsmaeder
Copy link
Contributor

Well, we added a lot of API, did you recently try to run the camel extension in Theia again?

@apupier
Copy link
Contributor Author

apupier commented Apr 10, 2019

no, I haven't recently try to run the Camel Extension but this issue is about XML in general.

@apupier
Copy link
Contributor Author

apupier commented Apr 18, 2019

this issue is about pure XML.
As the item to have xml support in Che is closed, it means that it has been done for Theia: #12437

@apupier apupier closed this as completed Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Development

No branches or pull requests

5 participants