Include existing GitHub plugin in Che Theia IDE

[ashumilova]

There is VSCode extension for GitHub integration - https://marketplace.visualstudio.com/items?itemName=GitHub.vscode-pull-request-github, the idea is to make it work with Che Theia and publish it on plugin registry.

[benoitf]

hello, why should it be inside the theia image ?

[mmorhun]

Currently we are missing at least

1. globalState from plugin context implementation (issue)
2. ProgressOptions, ProgressLocation form global namespace and withProgress from window API (PR in progress)
3. Open link VSCode command (internal id vscode.open) (issue)
4. getWorkspaceFolder from workspace namespace (issue)

Full list of commands:

Command	Investigated	Issues to resolve
Set Personal Access Token...	Yes	1
Setup GitHub Enterprise Token...	Yes	1
Setup Gitlab Token...	Yes	1
Remove Token...	Yes	1
Browse project	Yes	1, 2, 3
Create pull request...	Yes	2, *
Create pull request from current branch in current repository (quick)	Yes	2, *
Checkout open pull request...	Yes	2, **
Browse pull request of current branch	Yes	2, 3
Browse open pull request...	Yes	2, 3
Merge pull request (current branch)...	Yes	2
Add assignee to pull request...	Yes	2
Remove assignee from pull request...	Yes	2
Request a review for the current pull request...	Yes	2
Cancel a pull request review...	Yes	2
Browse open issue...	Yes	2, 3
Browse current file	Yes	2, 3, 4

* It works, but after everything is done a notification popup is shown which suggest to open just created pull request. To have this working we need 3

** Behavior slightly differs in Theia and Vscode. Vscode silently creates a local branch to checkout a PR, Theia instead proposes to select a local branch or create a new one.

All commands were tested with github.com only

[mmorhun]

Also there is a problem with the plugin code. In some environments it fails with:

Error: Class constructor LRUCache cannot be invoked without 'new'

[Trevor-K-Smith]

I'm still getting "Error: Class constructor LRUCache cannot be invoked without 'new'" with every npm action i try to perform. Is there something i can do to fix?

[mmorhun]

@Trevorks try to use the latest version of the plugin. AFAIK there is a fix for that problem and it has been released.

[vparfonov]

update plugin id: https://marketplace.visualstudio.com/items?itemName=GitHub.vscode-pull-request-github

[vinokurig]

Depends on eclipse-theia/theia#4103

[vinokurig]

Analyzing showed that this plugin requires VSCode Git extension:
https://github.com/Microsoft/vscode-pull-request-github/blob/master/src/extension.ts#L82.
VSCode Git extension uses SCM Plugin-Api:
https://github.com/Microsoft/vscode/blob/master/extensions/git/src/repository.ts#L577
witch is not implemented in Theia (Issue: eclipse-theia/theia#4103).
Anyway the plugin can work only on Theia with installed VSCode Git Extension. Theia with VSCode extensions is going to be done in eclipse-theia/theia#3815 and eclipse-theia/theia#3956

[l0rd]

We have reviewed this issue today with @vparfonov and now that the CQ to add VS Code built-in extensions to Theia has been approved we can proceed with:

• Including git extension in theia (if, for some reason, the PR takes long to get merged, we are going to include it in che-theia)
• review and merge the PR to include the Github extension in the plugin registry (Add Vscode Github plugin che-plugin-registry#175)