Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theia remote plugin runner should copy env vars when it starts plugin process #12298

Closed
garagatyi opened this issue Dec 27, 2018 · 4 comments
Closed
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.

Comments

@garagatyi
Copy link

Description

Some plugins use environment variables to find information about the system. For example location of JRE by JAVA_HOME env var (as Sonarlint does).
But when we run a plugin as remote env vars are not copied to the plugin process, so a plugin cannot find its dependency and ask a user to install it or configure its value in IDE settings.
We would provide better UX if we allow plugins automatically detect needed values.

Reproduction Steps

OS and version:

Diagnostics:

@garagatyi garagatyi added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Dec 27, 2018
@garagatyi
Copy link
Author

@benoitf FYI

@garagatyi
Copy link
Author

@evidolob are you planning to work on that or you are OK if we handle that to speed up delivery of Che 7?

@evidolob
Copy link
Contributor

evidolob commented Jan 8, 2019

I'm OK to let you handle it

@garagatyi
Copy link
Author

I figured out that env is not copied when a plugin is running in the main Theia container, not the remote runner. I'm closing the issue since it was a mistake.
BTW @tolusha already working on a solution for copying env for local plugins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Development

No branches or pull requests

3 participants