Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config Editor has no "Save" Button #12957

Closed
tsmaeder opened this issue Mar 22, 2019 · 5 comments
Closed

Config Editor has no "Save" Button #12957

tsmaeder opened this issue Mar 22, 2019 · 5 comments
Labels
kind/bug Outline of a bug - must adhere to the bug report template. kind/enhancement A feature request - must adhere to the feature request template.

Comments

@tsmaeder
Copy link
Contributor

  1. Create a Che 7 workspace
  2. "Save and continue editing"
  3. Go to the "Config" tab of the workspace editor
  4. Observe: there is no "Save" button for the editor.

All other tabs show a "Save" button at the bottom of the screen to save changes. This is inconsistent and confusing.

@tsmaeder tsmaeder added kind/bug Outline of a bug - must adhere to the bug report template. target/che7 labels Mar 22, 2019
@tsmaeder
Copy link
Contributor Author

tsmaeder commented Jun 21, 2019

When you make multiple changes, you get multiple dialogs saying "Workspace configuration has been updated", but you are not sure whether your latest changes have been saved or if the dialog comes from an older edit that has been saved. I find this behaviour extremely annoying when a "save" button that becomes enabled upon changes is a decades old, simple and clear UI for this.

@tsmaeder
Copy link
Contributor Author

Or if autosave is really necessary, at least provide a clear indication of the dirty status of the editor?

@sttyerase
Copy link

Repeating my comments from Mattermost: at the minimum from a standpoint of consistency, the "save" button should appear there. I have major challenges when UIs give inconsistent signals about behavior. Even the plugins selection UI engages the "save" button when a change is made.

@benoitf benoitf added kind/enhancement A feature request - must adhere to the feature request template. and removed kind/usability labels Jul 9, 2019
@mhockelberg
Copy link

In workshops with customers using Che, we have had feedback that having a consistent indicator to make user aware that changes have been saved and adding a "Save" button would make the user experience better. AND to consider making autosave an optional behavior/preference IDE setting for each user.

@mmorhun
Copy link
Contributor

mmorhun commented Nov 20, 2019

I think we may close this issue as Save button was added to workspace configuration page in #14913

@mmorhun mmorhun closed this as completed Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template. kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

No branches or pull requests

5 participants