Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Find All references" is always disabled #13183

Closed
apupier opened this issue Apr 18, 2019 · 15 comments
Closed

"Find All references" is always disabled #13183

apupier opened this issue Apr 18, 2019 · 15 comments
Labels
kind/bug Outline of a bug - must adhere to the bug report template.

Comments

@apupier
Copy link
Contributor

apupier commented Apr 18, 2019

Description

The "Find All references" action on right-click is greyed out on Camel files although it should be available.

image

it should even provides results when right-clicking on the "direct:name1" Find all references

it is working fine in VS Code:
image

image

Reproduction Steps

  • install Camel VS Code extension in Che
"attributes": {
    "editor": "org.eclipse.che.editor.theia:1.0.0",
    "plugins": "che-machine-exec-plugin:0.0.1,https://raw.githubusercontent.com/apupier/che-plugin-registry/109-AddApacheCamelVSCodeExtension/plugins/camel-tooling.vscode-apache-camel:0.0.14"
  }
  • create a camel.xml file
<?xml version="1.0" encoding="UTF-8"?>
<beans xmlns="http://www.springframework.org/schema/beans"
    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="        http://www.springframework.org/schema/beans http://www.springframework.org/schema/beans/spring-beans.xsd        http://camel.apache.org/schema/spring http://camel.apache.org/schema/spring/camel-spring.xsd">
    <camelContext id="cbr-example-context" xmlns="http://camel.apache.org/schema/spring">
        <route id="cbr-route">
            <from id="_from1" uri="timer:timerName?delay=1000"/>
            <to id="_to3" uri="direct:name1"/>
        </route>
         <route id="cbr-route">
            <from id="_from1" uri="direct:name1"/>
            <to id="_to3" uri="file:work/cbr/output/others"/>
        </route>
    </camelContext>
</beans>
  • right-click on "direct:name1"

--> the "Find all references" is greyed out

OS and version:

che.openshift.io
Windows 10
Chrome

Diagnostics:

@apupier apupier mentioned this issue Apr 18, 2019
23 tasks
@tsmaeder
Copy link
Contributor

Does "find all references" work for other plugins?

@apupier
Copy link
Contributor Author

apupier commented Apr 26, 2019

Does "find all references" work for other plugins?

that is a good question.
I know only the java plugin which is providing "Find all references" feature but I'm unable to install it on che.openshift.io today

@apupier
Copy link
Contributor Author

apupier commented Apr 29, 2019

I was able to install Python Language Server. it is not working neither with it. So looks alike a generic issue with "find references"

not working in Che
image

working in VS Code:
image

@apupier apupier changed the title Find references is not available for Camel direct component "Find All references" is always disabled Apr 29, 2019
@apupier
Copy link
Contributor Author

apupier commented Apr 29, 2019

finally able to install Java. And there is also the same problem:
image

working in VS Code:
image

@apupier
Copy link
Contributor Author

apupier commented Apr 29, 2019

I tested with Camel example and it is working fine in Theia.

@ibuziuk ibuziuk added kind/bug Outline of a bug - must adhere to the bug report template. team/languages labels Apr 29, 2019
@tsmaeder
Copy link
Contributor

tsmaeder commented May 3, 2019

@apupier so are you saying this is fixed?

@apupier
Copy link
Contributor Author

apupier commented May 5, 2019

@apupier so are you saying this is fixed?

no.
it is working in Theia standalone but not in Theia inside Che.

@tolusha
Copy link
Contributor

tolusha commented May 6, 2019

Tested on minishift, workspace attributes:

 "attributes": {
    "editor": "org.eclipse.che.editor.theia:next",
    "plugins": "che-machine-exec-plugin:0.0.1,https://raw.githubusercontent.com/eclipse/che-plugin-registry/master/plugins/camel-tooling.vscode-apache-camel:0.0.14",
    "persistVolumes": "false"
  },

Screenshot from 2019-05-06 13-07-37

@apupier
Copy link
Contributor Author

apupier commented May 6, 2019

tried again, it is working with org.eclipse.che.editor.theia:next and not working with org.eclipse.che.editor.theia:1.0.0 which is the one selected by default.

@tolusha
Copy link
Contributor

tolusha commented May 6, 2019

1.0.0 probably outdated version and findAllReferences weren't implemented there.
Can we close the issue?

@apupier
Copy link
Contributor Author

apupier commented May 6, 2019

Can we close the issue?

I think it depends on the methodology used in Che.

suggestion:

  • check that there is an automated test for this feature
    • if no, it would be better to write it before closing (or at least create a specific task for it before closing)
    • if yes, can be closed.

@tolusha
Copy link
Contributor

tolusha commented May 7, 2019

What do you mean by "automated test" ?

@apupier
Copy link
Contributor Author

apupier commented May 7, 2019

What do you mean by "automated test" ?

I mean a test which is executed on a Continuous Integration server on each build/Pull Request of Che or one of its components.

@tolusha
Copy link
Contributor

tolusha commented May 7, 2019

We have api tests eclipse-theia/theia#4224
If we are talking about e2e test then it is question for QE team.
There is nothing we can do here.

@apupier
Copy link
Contributor Author

apupier commented May 7, 2019

if there is unit test, we are in the case "if yes, can be closed" :-)

@apupier apupier closed this as completed May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Development

No branches or pull requests

4 participants